Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Fix double use of the same schema #130

Closed
Totktonada opened this issue Apr 23, 2018 · 2 comments
Closed

Fix double use of the same schema #130

Totktonada opened this issue Apr 23, 2018 · 2 comments
Labels
bug Something isn't working customer
Milestone
0.0.1

Comments

@Totktonada
Copy link
Member

It does not work due to assert on state.definitions.
@Totktonada Totktonada added bug Something isn't working customer labels Apr 23, 2018
@Totktonada Totktonada added this to the 0.0.1 milestone Apr 23, 2018
Totktonada added a commit that referenced this issue Apr 24, 2018
@Totktonada
WIP: Allow to reuse schema for several collections
d6b6277 
Fixes #130.
@Totktonada Totktonada mentioned this issue Apr 24, 2018
Merged
@Totktonada
Copy link
Member Author

There is dirty fix in the PR #132. I would worked the bug around using more general approach: namespaces for graphql types (like in avro-schema), but I need to read into the standard deeper to decide. Postponed for now (until 2018-04-26).

Totktonada added a commit that referenced this issue May 30, 2018
@Totktonada
Allow to reuse schema for several collections
fd9bc04 
Fixes #130.
@Totktonada
Copy link
Member Author

Decided to proceed with the current implementation in PR #132, because it solves the current customer’s problem. The alternative with namespaces likely will break the type introspection and requires some considerable effort to be moved from 'raw and unclear idea' state.

Totktonada added a commit that referenced this issue May 30, 2018
@Totktonada
Allow to reuse schema for several collections
5eb048b 
Fixes #130.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working customer
Projects
None yet
Milestone
0.0.1
Development

No branches or pull requests
1 participant
@Totktonada