Wrong variable "var" for the Scalar "Float" if value is greater than 10^15 #47
Comments
Totktonada
added a commit
that referenced
this issue
Apr 1, 2022
It is quite usual that a floating point number is encoded using JSON, goes over HTTP, received on tarantool server, decoded from JSON and passed as a variable into the GraphQL executor. A number out of the [-10^14+1; 10^14-1] range is decoded into Lua as cdata number[^1] to don't loss the precision. A JSON decoder don't know that we intend to use this value as the floating point one and chooses the conservative option: decode the value into cdata number to don't loss the precision. In GraphQL we know that it is actually the floating point value (disregarding its representation in Lua). So it looks correct to accept a cdata number as value of a Float variable. The similar idea was expressed in [1] against tarantool itself: let it accept a number without fractional part as a value suitable for the `float` field type. [1]: tarantool/tarantool#5933 [^1]: `cdata<int64_t>` or `cdata<uint64_t>` Fixes #47
Totktonada
added a commit
that referenced
this issue
Apr 1, 2022
The GraphQL specification explicitly forbids it: | Non-finite floating-point internal values (NaN and Infinity) cannot | be coerced to Float and must raise a field error. http://spec.graphql.org/October2021/#sec-Float Follows up #47
Totktonada
added a commit
that referenced
this issue
Apr 4, 2022
It is quite usual that a floating point number is encoded using JSON, goes over HTTP, received on tarantool server, decoded from JSON and passed as a variable into the GraphQL executor. A number out of the [-10^14+1; 10^14-1] range is decoded into Lua as cdata number[^1] to don't loss the precision. A JSON decoder don't know that we intend to use this value as the floating point one and chooses the conservative option: decode the value into cdata number to don't loss the precision. In GraphQL we know that it is actually the floating point value (disregarding its representation in Lua). So it looks correct to accept a cdata number as value of a Float variable. The similar idea was expressed in [1] against tarantool itself: let it accept a number without fractional part as a value suitable for the `float` field type. [1]: tarantool/tarantool#5933 [^1]: `cdata<int64_t>` or `cdata<uint64_t>` Fixes #47
Totktonada
added a commit
that referenced
this issue
Apr 4, 2022
The GraphQL specification explicitly forbids it: | Non-finite floating-point internal values (NaN and Infinity) cannot | be coerced to Float and must raise a field error. http://spec.graphql.org/October2021/#sec-Float Follows up #47
Totktonada
added a commit
that referenced
this issue
Apr 4, 2022
It is quite usual that a floating point number is encoded using JSON, goes over HTTP, received on tarantool server, decoded from JSON and passed as a variable into the GraphQL executor. A number out of the [-10^14+1; 10^14-1] range is decoded into Lua as cdata number[^1] to don't loss the precision. A JSON decoder don't know that we intend to use this value as the floating point one and chooses the conservative option: decode the value into cdata number to don't loss the precision. In GraphQL we know that it is actually the floating point value (disregarding its representation in Lua). So it looks correct to accept a cdata number as value of a Float variable. The similar idea was expressed in [1] against tarantool itself: let it accept a number without fractional part as a value suitable for the `float` field type. [1]: tarantool/tarantool#5933 [^1]: `cdata<int64_t>` or `cdata<uint64_t>` Fixes #47
Totktonada
added a commit
that referenced
this issue
Apr 4, 2022
The GraphQL specification explicitly forbids it: | Non-finite floating-point internal values (NaN and Infinity) cannot | be coerced to Float and must raise a field error. http://spec.graphql.org/October2021/#sec-Float Follows up #47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: