Skip to content

More cases for fuzzing nullability test #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DifferentialOrange opened this issue Aug 26, 2022 · 0 comments
Open

More cases for fuzzing nullability test #63

DifferentialOrange opened this issue Aug 26, 2022 · 0 comments
Labels
code health Improve code readability, simplify maintenance and so on

Comments

@DifferentialOrange
Copy link
Member

DifferentialOrange commented Aug 26, 2022 •
edited
Loading

PR #59 original fuzzing nullability test had introduced cases for multiple arguments and variables, also supported running with input types and custom scalars. Rework #64 does not include them due to absence of time resources (and since it seems a bit excessive). But it would be nice to restore them.
DifferentialOrange added a commit that referenced this issue Aug 26, 2022
@DifferentialOrange
Test argument and variable nullability
1c286a5 
Compare library with JS reference implementation in various nullability
cases. This patch uses JS script to build various schemas and queries
and execute them to generate luatest script that verifies that this
library has the same behavior.

To generate script, run
```bash
cd ./tests/integration/codegen/fuzzing_nullability
npm install
node ./generate.js > ../../fuzzing_nullability_test.lua
```

Prior to this patch, several nullability behavior issues were fixed.
There is some case that isn't yet fully covered by our library, refer
to [1] for updates.

Follow [2] for more test cases.

Based on @no1seman PR [3].

1. #62
2. #63
3. #59
@DifferentialOrange DifferentialOrange mentioned this issue Aug 26, 2022
Merged
@DifferentialOrange DifferentialOrange changed the title #59 follow up test cases placeholder More cases for fuzzing nullability test Aug 26, 2022
@DifferentialOrange DifferentialOrange added code health Improve code readability, simplify maintenance and so on teamE labels Aug 26, 2022
@DifferentialOrange DifferentialOrange mentioned this issue Aug 26, 2022
Closed
DifferentialOrange added a commit that referenced this issue Aug 26, 2022
@DifferentialOrange
Test argument and variable nullability
ebe9be4 
Compare library with JS reference implementation in various nullability
cases. This patch uses JS script to build various schemas and queries
and execute them to generate luatest script that verifies that this
library has the same behavior.

To generate script, run
```bash
cd ./tests/integration/codegen/fuzzing_nullability
npm install
node ./generate.js > ../../fuzzing_nullability_test.lua
```

Prior to this patch, several nullability behavior issues were fixed.
There is some case that isn't yet fully covered by our library, refer
to [1] for updates.

Follow [2] for more test cases.

Based on @no1seman PR [3].

1. #62
2. #63
3. #59
@DifferentialOrange DifferentialOrange mentioned this issue Sep 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code health Improve code readability, simplify maintenance and so on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DifferentialOrange @TarantoolBot