Improve returning data and errors from request #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no1seman
changed the title
olegrok
reviewed
Oct 3, 2021
no1seman
force-pushed
the
data_errors_improved
branch
from
e555789 to
204e2e5
Compare
DifferentialOrange
pushed a commit
that referenced
this pull request
Nov 15, 2021
32c97f0 introduced returning data and errors acc. spec #7.1.2 but previous implementation didn't take into account that execution may include multiple resolvers and each of them may return both data and errors. This PR fixes the logic to collect all errors from all resolvers into a single map that can be returned to requester. Based on PR #19 by @no1seman
|
I was finishing this PR as a part of this sprint tasks. You can see reworked version in #25 . Since this PR is based on branch of no1seman/graphql which I have no access to, I have opened a new PR. |
DifferentialOrange
pushed a commit
that referenced
this pull request
Nov 18, 2021
32c97f0 introduced returning data and errors acc. spec #7.1.2 but previous implementation didn't take into account that execution may include multiple resolvers and each of them may return both data and errors. This PR fixes the logic to collect all errors from all resolvers into a single array that can be returned to requester. Based on PR #19 by @no1seman
Totktonada
pushed a commit
that referenced
this pull request
Nov 18, 2021
32c97f0 introduced returning data and errors acc. spec #7.1.2 but previous implementation didn't take into account that execution may include multiple resolvers and each of them may return both data and errors. This PR fixes the logic to collect all errors from all resolvers into a single array that can be returned to requester. Based on PR #19 by @no1seman
|
Closed with #25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
32c97f0 introduced returning data and errors acc. spec #7.1.2 but previous implementation didn't take in account that execution may include multiple resolvers and each of them may return both data and errors. This PR fixes the logic to collect all errors from all resolvers into single map that can be returned to requestor.