-
Notifications
You must be signed in to change notification settings - Fork 3
Improve returning data and errors from request #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second commit is ok. I think you could remove the first one. See one comment below.
e555789
to
204e2e5
Compare
32c97f0 introduced returning data and errors acc. spec #7.1.2 but previous implementation didn't take into account that execution may include multiple resolvers and each of them may return both data and errors. This PR fixes the logic to collect all errors from all resolvers into a single map that can be returned to requester. Based on PR #19 by @no1seman
I was finishing this PR as a part of this sprint tasks. You can see reworked version in #25 . Since this PR is based on branch of no1seman/graphql which I have no access to, I have opened a new PR. |
32c97f0 introduced returning data and errors acc. spec #7.1.2 but previous implementation didn't take into account that execution may include multiple resolvers and each of them may return both data and errors. This PR fixes the logic to collect all errors from all resolvers into a single array that can be returned to requester. Based on PR #19 by @no1seman
32c97f0 introduced returning data and errors acc. spec #7.1.2 but previous implementation didn't take into account that execution may include multiple resolvers and each of them may return both data and errors. This PR fixes the logic to collect all errors from all resolvers into a single array that can be returned to requester. Based on PR #19 by @no1seman
Closed with #25 |
32c97f0 introduced returning data and errors acc. spec #7.1.2 but previous implementation didn't take in account that execution may include multiple resolvers and each of them may return both data and errors. This PR fixes the logic to collect all errors from all resolvers into single map that can be returned to requestor.