Skip to content

Improve returning data and errors from request #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

no1seman
Copy link

@no1seman no1seman commented Oct 2, 2021

32c97f0 introduced returning data and errors acc. spec #7.1.2 but previous implementation didn't take in account that execution may include multiple resolvers and each of them may return both data and errors. This PR fixes the logic to collect all errors from all resolvers into single map that can be returned to requestor.

@no1seman no1seman requested review from olegrok and Totktonada October 2, 2021 11:52
@no1seman no1seman changed the title Improve returninng data and errors from request Improve returning data and errors from request Oct 2, 2021
Copy link
Collaborator

@olegrok olegrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second commit is ok. I think you could remove the first one. See one comment below.

@no1seman no1seman force-pushed the data_errors_improved branch from e555789 to 204e2e5 Compare October 3, 2021 10:43
@no1seman no1seman requested a review from olegrok October 3, 2021 10:52
DifferentialOrange pushed a commit that referenced this pull request Nov 15, 2021
32c97f0 introduced returning data and errors acc. spec #7.1.2 but
previous implementation didn't take into account that execution may
include multiple resolvers and each of them may return both data and
errors. This PR fixes the logic to collect all errors from all resolvers
into a single map that can be returned to requester.

Based on PR #19 by @no1seman
@DifferentialOrange
Copy link
Member

I was finishing this PR as a part of this sprint tasks. You can see reworked version in #25 . Since this PR is based on branch of no1seman/graphql which I have no access to, I have opened a new PR.

DifferentialOrange pushed a commit that referenced this pull request Nov 18, 2021
32c97f0 introduced returning data and errors acc. spec #7.1.2 but
previous implementation didn't take into account that execution may
include multiple resolvers and each of them may return both data and
errors. This PR fixes the logic to collect all errors from all resolvers
into a single array that can be returned to requester.

Based on PR #19 by @no1seman
Totktonada pushed a commit that referenced this pull request Nov 18, 2021
32c97f0 introduced returning data and errors acc. spec #7.1.2 but
previous implementation didn't take into account that execution may
include multiple resolvers and each of them may return both data and
errors. This PR fixes the logic to collect all errors from all resolvers
into a single array that can be returned to requester.

Based on PR #19 by @no1seman
@DifferentialOrange
Copy link
Member

Closed with #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants