Skip to content

Support scalar specification URL #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DifferentialOrange
Copy link
Member

@DifferentialOrange DifferentialOrange commented Nov 19, 2021

Rework of #21 .

When defining a custom scalar, GraphQL services should provide a scalar specification URL via the @specifiedBy directive or the specifiedByURL introspection field (spec. #3.5). This patch introduces support of these tools.

Reworks: add test for directive, change directive name to @specifiedBy based on spec, add commit message.

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/no1seman-specifiedby_directive branch 2 times, most recently from 8a06849 to 226ff41 Compare November 23, 2021 09:14
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from me. @olegrok?

When defining a custom scalar, GraphQL services should provide a scalar
specification URL via the @specifiedBy directive or the specifiedByURL
introspection field (spec. #3.5 [1]). This patch introduces support of
these tools.

1. https://spec.graphql.org/draft/#sec-Scalars.Custom-Scalars

Based on PR #21 by @no1seman
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/no1seman-specifiedby_directive branch from 226ff41 to 0974be5 Compare November 30, 2021 06:17
@DifferentialOrange
Copy link
Member Author

Rebased, ready to merge

@Totktonada Totktonada merged commit 7d2e9c9 into master Nov 30, 2021
@Totktonada Totktonada deleted the DifferentialOrange/no1seman-specifiedby_directive branch November 30, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants