Fix coercing default values on schema generation #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
reviewed
Jan 11, 2022
|
We discussed the questions with Yaroslav in voice and he'll return back with updates/clarification. |
|
Well, since there are some changes planned, I will not review the current version and wait for the update |
no1seman
force-pushed
the
fix_defaults_coerce
branch
from
423886e to
f7b11a2
Compare
DifferentialOrange
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Well, the PR definitely does what it intends to do.
It is a bit unsatisfying that defaultValues are still seems to be broken after this PR, but it seems like the feature is not that highly demanded and it will be processed as a part of standard working pipeline. I added a ticket to backlog, its priority may be changed if someone will request it, see #37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch:
[x] Tests