Propagate defaults to operation callback #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no1seman
force-pushed
the
propagate_defaults
branch
from
7d3772c to
2da81e7
Compare
DifferentialOrange
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
Seems ok. As always, thank you for your PR! You'll need to rebase on master and fix possible conflicts with #44 before merge
Totktonada
approved these changes
Jan 31, 2022
Before this PR there is no fast and convenient way to get operation and directives defaults set when creating the schema. Now it's possible, operation and directives default can be easily found is in the #3 argument of callback - map "info". The keys are: defaultValues - for operation defaults directivesDefaultValues - for directives defaults
no1seman
force-pushed
the
propagate_defaults
branch
from
2da81e7 to
e289cfe
Compare
Totktonada
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR there is no fast and convenient way to get
operation and directives defaults set when creating the schema.
Now it's possible, operation and directives default can be easily found
is in the #3 argument of callback - map "info". The keys are:
defaultValues - for operation defaults
directivesDefaultValues - for directives defaults
There will be no defaults propageted by default. To make it available must set 2 options:
schema.create(config, name, {defaultValues = true, directivesDefaultValues = true})
This will done to make schema creation a little be faster when one don't need defaults to be propagated.
closes: #37