Fix memory allocate during request processing #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tarantool modules tests shouldn't compare box.stat() output because it can include different numbers of fields in different versions of tarantool.
Before introducing a txn memory region box_txn_alloc() allocates memory using the fiber.gc region and can be used without box_txn_begin(). Now the similar trick doesn't work (a transaction must be started). To allocate memory on region without start a transaction, the region was added to struct memcached_connection. Fixes #53
LeonidVas
force-pushed
the
lvasilev/gh-53-fix-memory-allocate
branch
from
6591b28 to
954c0af
Compare
|
Got segfault on both master and this patchset on tarantool 2.5.0-62-gbb7c3d167 (debug) when run tests (cd test && ./test-run.py). Don't sure, how it is related to the problem you solve here. My intention was to get some 'problem solved' criteria: say, run tests om memcached from It would be glad, if you'll glance on this segfault. |
D'oh! I tested it only with a release build. But this is a different bug (see #59) |
|
Run the existing test suites on master (+small update) and on this branch (+small update). The tests don't pass on master and pass on the branch, so now I verified that the problem is actually fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before introducing a txn memory region box_txn_alloc() allocates memory using the fiber.gc region and can be used without box_txn_begin(). Now the similar trick doesn't work (a transaction must be started).
To allocate memory on region without start a transaction, the region was added to struct memcached_connection.
Fixes #53