fiber.yield() call removed from quantile #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngvar-antonsson
force-pushed
the
remove-fiber-yield
branch
from
dc1f627 to
ea534ac
Compare
|
lgtm |
yngvar-antonsson
force-pushed
the
remove-fiber-yield
branch
from
715e333 to
3bc3024
Compare
filonenko-mikhail
approved these changes
May 24, 2021
vasiliy-t
approved these changes
May 24, 2021
| for _=1,500 do | ||
| fiber.create(function() | ||
| for _=1,1e2 do | ||
| t.assert(q1.b_len < q1.__max_samples) |
There was a problem hiding this comment.
is it possible to reduce test execution time with reduced __max_samples? if this is the case this should be done
.github/workflows/test.yml
Outdated
| @@ -65,3 +67,14 @@ jobs: | |||
| run: | | |||
| GO111MODULE=on go get github.com/prometheus/prometheus/cmd/promtool@a6be548dbc17780d562a39c0e4bd0bd4c00ad6e2 | |||
| make test_promtool | |||
| stress-test: | |||
There was a problem hiding this comment.
if it is possible to reduce execution time then we should move this test to unit instead of it's own stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fiber.yield()call leads to quantile overflow and segfault.Unfortunately, test that shows overflow is highly stressed and can't be run with other tests. You can see repro run in actions history. I also moved that test to release stage.
I didn't forget about
Close #235