Skip to content

Add upper constraint to quicksort #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2021
Merged

Add upper constraint to quicksort #332

merged 1 commit into from
Dec 17, 2021
+13 −0

Conversation

yngvar-antonsson
Copy link
Collaborator

@yngvar-antonsson yngvar-antonsson commented Dec 8, 2021 •
edited
Loading

Added to ensure that #235 won't come back

I didn't forget about

  • Tests

@yngvar-antonsson yngvar-antonsson added bug Something isn't working teamS labels Dec 8, 2021
sergos
sergos approved these changes Dec 17, 2021
View reviewed changes
Copy link

@sergos sergos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

At first I thought the assert can be changed for update of the low and high. But it will not help to find the bug why appeared beyond the limits - the interface is internal.

@yngvar-antonsson yngvar-antonsson merged commit 4af1925 into master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergos sergos sergos approved these changes

@filonenko-mikhail filonenko-mikhail Awaiting requested review from filonenko-mikhail

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yngvar-antonsson @sergos