New version module info & Release 0.16.0 #426
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, it was assumed that version would be set automatically with CI. Yet, current approach don't work. This patch replaces this approach with simple manual solution. The rules are as follows: - bump version to X.Y.Z in release commit, - bump version to X.Y.Z-scm in the following commit. luarocks.core.vers comparison treats scm version as we expect them to: - X.Y.Z-scm > X.Y.Z - X.Y.Z+1 > X.Y.Z-scm - X.Y+1.0 > X.Y.Z-scm - X+1.0.0 > X.Y.Z-scm The version approach may be reworked later, but since we need a valid version info for tarantool/tarantool#8192, we implement this one at least for now. Closes #330, part of tarantool/tarantool#8192
As a part of new module policy, each module must have version info stored in module._VERSION. For now, metrics._VERSION a duplicate of metrics.VERSION, but the latter is likely to be deprecated later.
DifferentialOrange
force-pushed
the
DifferentialOrange/release-0.16.0
branch
from
4d063e5 to
af634ba
Compare
yngvar-antonsson
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces the fix of existing module version info together with new version providing policy (potentially temporary). It is a prerequirement to tarantool/tarantool#8192.
New
VERSION/_VERSIONis a plain Lua string controlled by the developer.The rules are as follows:
luarocks.core.verscomparison treats scm version as we expect them to:This PR is also a 0.16.0 release patch.
I didn't forget about
Close #330, part of tarantool/tarantool#8192