Skip to content

gather_job_data: detect specific before generic #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NickVolynkin
Copy link
Contributor

@NickVolynkin NickVolynkin commented Aug 30, 2022

Detect specific failure reasons first. If none found in the whole log,
look for generic. This way, specific reasons aren't overshadowed by
generic ones, when those are found first in the logs.

Introduce one specific reason: "Address already in use", subject of
tarantool/test-run#141

test name before after
total 47 47
testrun_address_already_in_use 0 19
testrun_test_failed 11 4
dpkg_buildpackage_error 9 0
unknown 8 8
integration_vshard_test_failed 4 3
testrun_test_hung 3 3 3
dir_not_empty 3 3 3
testrun_internal 2 2
integration_tests_failed 2 2
jepsen_error 2 2
luajit_error 1 1
git_repo_access_error 1 1

@github-actions github-actions bot temporarily deployed to test August 30, 2022 07:18 Inactive
@NickVolynkin NickVolynkin force-pushed the nickvolynkin/add-failure-address-already-in-use branch from 886117f to d286b99 Compare August 30, 2022 07:47
@github-actions github-actions bot temporarily deployed to test August 30, 2022 07:47 Inactive
@NickVolynkin NickVolynkin changed the title gather_job_data: detect "Address already in use" gather_job_data: detect specific before generic Aug 30, 2022
@NickVolynkin NickVolynkin marked this pull request as ready for review August 30, 2022 07:53
@NickVolynkin NickVolynkin force-pushed the nickvolynkin/add-failure-address-already-in-use branch from d286b99 to 5e371be Compare August 30, 2022 07:55
@github-actions github-actions bot temporarily deployed to test August 30, 2022 07:56 Inactive
Detect specific failure reasons first. If none found in the whole log,
look for generic. This way, specific reasons aren't overshadowed by
generic ones, when those are found first in the logs.

Introduce one specific reason: "Address already in use", subject of
tarantool/test-run#141
@NickVolynkin NickVolynkin force-pushed the nickvolynkin/add-failure-address-already-in-use branch from 5e371be to 4147334 Compare August 30, 2022 07:57
@github-actions github-actions bot temporarily deployed to test August 30, 2022 07:58 Inactive
@NickVolynkin NickVolynkin merged commit bf38c5e into master Aug 30, 2022
@NickVolynkin NickVolynkin deleted the nickvolynkin/add-failure-address-already-in-use branch August 30, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants