-
Notifications
You must be signed in to change notification settings - Fork 53
Release all taken tasks on start #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release all taken tasks on start #106
Conversation
Test fails (deploy fails) are not related with changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments below.
33721d0
to
94c0997
Compare
Let's add 'test' prefix. |
I put two 'FIXUP' commits. The first one squashed duplicated testing code. It also adds the test for limfifottl. The second one adds more logs and checking of tarantool version (as was proposed before). It also fixes the potential problem: After the fixups I'm happy with the change. If you're too, please, squash the fixups into the base commit and I'll proceed with the patchset. |
About common tests. I think about it, but I'm disagree with proposed concept. If look at drivers tests it have many copy-paste code. My point of view: "We must to have some common tests which will be run for all/some drivers from list". And this is not related to the patch. |
The test case should be either referenced from a certail test file (like We discussed it more with Leonid and he want to keep current way for now and make deduplication separately. I would do it like proposed above, but this way is okay too.
It is implementation detail, but we test public API of a driver. So I would left the test here. |
b17a38b
to
ff1e9c9
Compare
All taken tasks will be released after the server restart If some tasks have been taken and don't released before shutdown of the tarantool instance (for example: tarantool instance has been killed) such task go to 'hung' state (noone can take the task now). So, we must release all taken tasks on start of the queue module. Fixes #66
9e5cdae
to
0bfc6c5
Compare
Updated |
limfifottl does not duplicate fifottl tests. So, let's continue to go that way |
0bfc6c5
to
471cc03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
If some tasks have been taken and don't released before shutdown
of the tarantool instance (for example: tarantool instance has been killed)
such task go to 'hung' state (noone can take the task now).
So, we must release all taken tasks on start of the queue module.
Fixes #66