Skip to content

NOTASK: make tarantool-queue reloadable with moonlibs/package.reload #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions queue/abstract/driver/fifottl.lua
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ function tube.new(space, on_task_change, opts)
}, { __index = method })

self.cond = qc.waiter()
self.fiber = fiber.create(fifottl_fiber, self)
self.fiber = util.background_fiber(fifottl_fiber, self)
self.sync_chan = fiber.channel()

return self
Expand Down Expand Up @@ -412,7 +412,7 @@ function method.start(self)
if self.fiber then
return
end
self.fiber = fiber.create(fifottl_fiber, self)
self.fiber = util.background_fiber(fifottl_fiber, self)
end

function method.stop(self)
Expand Down
4 changes: 2 additions & 2 deletions queue/abstract/driver/utubettl.lua
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ function tube.new(space, on_task_change, opts)
}, { __index = method })

self.cond = qc.waiter()
self.fiber = fiber.create(utubettl_fiber, self)
self.fiber = util.background_fiber(utubettl_fiber, self)
self.sync_chan = fiber.channel(1)

return self
Expand Down Expand Up @@ -741,7 +741,7 @@ function method.start(self)
if self.fiber then
return
end
self.fiber = fiber.create(utubettl_fiber, self)
self.fiber = util.background_fiber(utubettl_fiber, self)
end

function method.stop(self)
Expand Down
2 changes: 1 addition & 1 deletion queue/abstract/queue_session.lua
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ end

--- Create an expiration fiber to cleanup expired sessions.
local function create_expiration_fiber()
local exp_fiber = fiber.create(function()
local exp_fiber = util.background_fiber(function()
fiber.self():name('queue_expiration_fiber')
while true do
if box.info.ro == false then
Expand Down
3 changes: 2 additions & 1 deletion queue/abstract/queue_state.lua
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

local log = require('log')
local fiber = require('fiber')
local util = require('queue.util')

--[[ States switching scheme:

Expand Down Expand Up @@ -62,7 +63,7 @@ end
local function create_state_fiber(on_state_change_cb)
log.info('Started queue state fiber')

fiber.create(function()
util.background_fiber(function()
fiber.self():name('queue_state_fiber')
while true do
if current == queue_state.states.WAITING then
Expand Down
3 changes: 2 additions & 1 deletion queue/init.lua
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ local abstract = require('queue.abstract')
local queue_state = require('queue.abstract.queue_state')
local qc = require('queue.compat')
local queue = nil
local util = require('queue.util')

-- load all core drivers
local core_drivers = {
Expand Down Expand Up @@ -107,7 +108,7 @@ local function wrap_box_cfg()
cfg_mt.__call = cfg_call_wrapper
else
-- Wait for the rw state.
fiber.new(rw_waiter)
util.background_fiber(rw_waiter)
end
else
error('The box.cfg type is unexpected: ' .. type(box.cfg))
Expand Down
20 changes: 19 additions & 1 deletion queue/util.lua
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,23 @@ local function event_time(tm)
return tm
end

local function background_fiber(func, ...)
local fib = fiber.new(func, ...)

if not package.reload then
return fib
end

fib:set_joinable(true)

package.reload:register(function()
fib:cancel()
fib:join()
end)

return fib
end

local util = {
MAX_TIMEOUT = MAX_TIMEOUT,
TIMEOUT_INFINITY = TIMEOUT_INFINITY
Expand All @@ -42,7 +59,8 @@ local util = {
-- methods
local method = {
time = time,
event_time = event_time
event_time = event_time,
background_fiber = background_fiber,
}

return setmetatable(util, { __index = method })