Skip to content

jdbc: Raise SQLException on Connection methods for a closed connection #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Totktonada opened this issue Nov 1, 2018 · 0 comments · Fixed by #153
Closed

jdbc: Raise SQLException on Connection methods for a closed connection #72

Totktonada opened this issue Nov 1, 2018 · 0 comments · Fixed by #153
Assignees
@nicktorwald
Labels
bug Something isn't working jdbc
Milestone
JDBC MVP

Comments

@Totktonada
Copy link
Member

The API states that the exception should be raised when a method is called on a closed connection. It is so for most of the methods. We don't raise it for some 'dumb' methods like getWarnings / clearWarnings, but it seems we must.
@Totktonada Totktonada added bug Something isn't working jdbc labels Nov 1, 2018
@Totktonada Totktonada added this to the JDBC MVP milestone Nov 1, 2018
nicktorwald added a commit that referenced this issue Apr 8, 2019
@nicktorwald
Raise SQLException on methods of a closed Connection
3dbee96 
Add missed checks on methods of the closed connection.

Add basic implementation Connection.isValid method to check a connection
state sending a simple ping request. A support of the timeout param
requires implementation of timer task per statement and comes out of the
scope this issue.

Closes: #72
Affects: #119
@nicktorwald nicktorwald mentioned this issue Apr 8, 2019
Merged
nicktorwald added a commit that referenced this issue Apr 8, 2019
@nicktorwald
Raise SQLException on methods of a closed Connection
42c9276 
Add missed checks on methods of the closed connection.

Add basic implementation Connection.isValid method to check a connection
state sending a simple ping request. A support of the timeout param
requires implementation of timer task per statement and comes out of the
scope this issue.

Closes: #72
Affects: #119
@nicktorwald nicktorwald self-assigned this Apr 8, 2019
nicktorwald added a commit that referenced this issue Apr 9, 2019
@nicktorwald
Raise SQLException on methods of a closed Connection
a616415 
Add missed checks on methods of the closed connection.

Closes: #72
Affects: #119, #74
nicktorwald added a commit that referenced this issue Apr 9, 2019
@nicktorwald
Raise SQLException on methods of a closed Connection
00232b7 
Add missed checks on methods of the closed connection.

Closes: #72
Affects: #119, #74
nicktorwald added a commit that referenced this issue Apr 17, 2019
@nicktorwald
Raise SQLException on methods of a closed Connection
25c0875 
Add missed checks on methods of the closed connection.

Closes: #72
Affects: #119, #74
nicktorwald added a commit that referenced this issue Apr 18, 2019
@nicktorwald
Raise SQLException on methods of a closed Connection
c047043 
Add missed checks on methods of the closed connection.

Closes: #72
Affects: #119, #74
nicktorwald added a commit that referenced this issue Apr 19, 2019
@nicktorwald
Raise SQLException on methods of a closed Connection
aaa404a 
Add missed checks on methods of the closed connection.

Closes: #72
Affects: #119, #74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicktorwald nicktorwald

Labels
bug Something isn't working jdbc
Projects
None yet
Milestone
JDBC MVP
Development

Successfully merging a pull request may close this issue.

Add missed checks on methods of the closed connection tarantool/tarantool-java
2 participants
@Totktonada @nicktorwald