Skip to content

AbstractJdbcIT test got broken by Tarantool server rework #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

nicktorwald
Copy link

According to tarantool/tarantool#3505 and tarantool/tarantool#3506
'box.sql.execute' is no longer supported in new Tarantool releases.

Fix AbstractJdbcIT class which used the obsolete expression. Now SQL
init scripts are performed by 'box.execute' statement superseded old
version.

Fixes: #149
See also: tarantool/tarantool#3505, tarantool/tarantool#3506

According to tarantool/tarantool#3505 and tarantool/tarantool#3506
'box.sql.execute' is no longer supported in new Tarantool releases.

Fix AbstractJdbcIT class which used the obsolete expression. Now SQL
init scripts are performed by 'box.execute' statement superseded old
version.

Fixes: #149
See also: tarantool/tarantool#3505, tarantool/tarantool#3506
@nicktorwald nicktorwald requested a review from Totktonada April 2, 2019 18:11
@nicktorwald
Copy link
Author

nicktorwald commented Apr 2, 2019

maybe it's better to avoid expressions like box.execute() due to volatile Tarantool API.
I mean we can use a safer approach like \set language sql + \set language lua to init jdbc tests. This allows us to write more stable tests independent on API breaking changes. This is a good point because tests can be run over a range of Tarantool versions.

@Totktonada
Copy link
Member

tarantool-2.1.2 should be released soon and after that the API should be backward compatible.

Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, waiting for CI.

@Totktonada
Copy link
Member

Totktonada commented Apr 2, 2019

https://travis-ci.org/tarantool/tarantool-java/jobs/514811291#L1989

[ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 43.32 s <<< FAILURE! - in org.tarantool.ClientReconnectIT
[ERROR] testLongParallelCloseReconnects  Time elapsed: 32.041 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:38)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:137)
	at org.tarantool.ClientReconnectIT.testLongParallelCloseReconnects(ClientReconnectIT.java:304)

@nicktorwald Is it due to #142?

@nicktorwald
Copy link
Author

nicktorwald commented Apr 2, 2019

It seems an old w-thread (or maybe a previous new one) hadn't released a state while the freshest w-thread tried to acquire the state. Looks related to #142

https://travis-ci.org/tarantool/tarantool-java/jobs/514811291#L1973

@Totktonada Totktonada merged commit 06755d5 into master Apr 2, 2019
@Totktonada Totktonada deleted the nicktorwald/gh-149-brokenAbstractJdbcIT branch April 2, 2019 20:01
@Totktonada
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants