Skip to content

JDBC batch updates #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2019
Merged

JDBC batch updates #203

merged 1 commit into from
Aug 7, 2019

Conversation

nicktorwald
Copy link

Add support for JDBC batch updates. It includes an implementation of
Statement.*Batch(...) as well as PreparedStatement.*Batch() methods.

Under the hood SQLConnection uses the pipelining sending requests one by
one asynchronously and awaiting all of them. There are some issues
regarding vinyl storage engine where execution order are not specified
and DDL statements which are not transactional.

Closes: #62

@nicktorwald nicktorwald force-pushed the nicktorwald/gh-62-batch-updates branch from 90f971e to 05bfde6 Compare July 6, 2019 05:59
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 73.228% when pulling 05bfde6 on nicktorwald/gh-62-batch-updates into b53e0ba on master.

Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The only comment. It would be good to mention guarantees we provide in README: I mean, say that batching guarantees order of execution for memtx engine, but does not for vinyl.

@nicktorwald
Copy link
Author

I didn't that, 'cause I thought It's worth describing in a separate document which is dedicated to JDBC driver user manual, isn't it?
README is ok, but too many JDBC things are required to be mentioned, so README can become too large for reading. Don't you think so?

@Totktonada
Copy link
Member

I don't want to miss such details. While we don't sure how the whole documentation will be structured and hosted, I think it is okay to dump such things to README. Another possible way to don't miss them is to file an issue with 'documentation' label, but this looks as an overcomplicated process for me.

So I propose to charge README with everything a user may want (as part of development process) and postpone structural questions for now. Once we'll define a structure, we'll split README to appropriate documents.

@nicktorwald nicktorwald force-pushed the nicktorwald/gh-62-batch-updates branch from 05bfde6 to 0969aad Compare August 7, 2019 13:14
Add support for JDBC batch updates. It includes an implementation of
Statement.*Batch(...) as well as PreparedStatement.*Batch() methods.

Under the hood SQLConnection uses the pipelining sending requests one by
one asynchronously and awaiting all of them. There are some issues
regarding vinyl storage engine where execution order are not specified
and DDL statements which are not transactional.

Closes: #62
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-62-batch-updates branch from 0969aad to 1d2c904 Compare August 7, 2019 15:42
@nicktorwald nicktorwald merged commit cdc0505 into master Aug 7, 2019
@nicktorwald nicktorwald deleted the nicktorwald/gh-62-batch-updates branch August 7, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jdbc: Batch command execution
3 participants