Skip to content

Support new types introduced in Tarantool 2.2 #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2019
Merged

Support new types introduced in Tarantool 2.2 #218

merged 1 commit into from
Aug 30, 2019

Conversation

nicktorwald
Copy link

There are a few new types such as BOOLEAN(BOOL), UNSIGNED in Tarantool
v2.2. Moreover, Number aliases REAL, FLOAT, DOUBLE were replaced by one
NUMBER type since v2.2.1.

Support tests for old number types on version before 2.2.

@nicktorwald nicktorwald changed the title Suuport new Tarantool types introduced in Tarantool 2.2 WIP: Support new Tarantool types introduced in Tarantool 2.2 Aug 13, 2019
@nicktorwald nicktorwald changed the title WIP: Support new Tarantool types introduced in Tarantool 2.2 WIP: Support new types introduced in Tarantool 2.2 Aug 13, 2019
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-92-tarantool-types-v22 branch 2 times, most recently from f039b43 to 335b923 Compare August 13, 2019 18:54
Totktonada
Totktonada approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, look which issues from #92 and linked into it are resolved and whether we need to do something more about them.

The commit is mostly okay. Please, consider comments below and proceed.

@nicktorwald nicktorwald force-pushed the nicktorwald/gh-92-tarantool-types-v22 branch 2 times, most recently from 15bdbfe to 15c93c2 Compare August 23, 2019 14:09
@nicktorwald nicktorwald changed the title WIP: Support new types introduced in Tarantool 2.2 Support new types introduced in Tarantool 2.2 Aug 23, 2019
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-92-tarantool-types-v22 branch from 15c93c2 to a865c7b Compare August 23, 2019 17:05
@nicktorwald nicktorwald mentioned this pull request Aug 23, 2019
Closed
@Totktonada
Copy link
Member

Let's close #67 instead of #214 from the commit message (the latter was closed as duplicate of the former). Let's close #92 from the commit and file another issue re implicit type conversions.

The only minor comment remains. Please, fix it and proceed.

@nicktorwald
Support new types introduced in Tarantool 2.2
60c3889 
There are a few new types such as BOOLEAN(BOOL), UNSIGNED, and VARBINARY
in Tarantool v2.2. Moreover, Number aliases REAL, FLOAT, DOUBLE were
replaced by one NUMBER type since v2.2.1.

Support tests for old number types on version before 2.2.

Closes: #67, #92, #209, #210
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-92-tarantool-types-v22 branch from a865c7b to 60c3889 Compare August 30, 2019 18:50
@nicktorwald nicktorwald merged commit 2cc1a09 into master Aug 30, 2019
@nicktorwald nicktorwald deleted the nicktorwald/gh-92-tarantool-types-v22 branch August 30, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Totktonada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicktorwald @Totktonada