travis-ci: run javadoc linter with travis #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
reviewed
Sep 1, 2020
There was a problem hiding this comment.
Nice to see new contributors!
Several minor comments re processes:
- Please, sink down
Fixes #xxxto the end of the commit message (see examples). Personally I feel placing links, issue number and other metainformation within a subject line as bad practice: the subject line has very restricted length (usually softly limited to 50 symbols), but should be as descriptive as possible. - We usually use prefixes to ease distinguish changes around tests, CI, a particular code subsystem, no-behaviour-changes refactoring. There is no restricted set of such prefixes, but for CI changes I usually use 'travis-ci: ' (where Travis-CI is used).
Artyomcool
force-pushed
the
travis-javadoc-check
branch
from
cca7bb0 to
ab8a8dc
Compare
Artyomcool
force-pushed
the
travis-javadoc-check
branch
from
ab8a8dc to
137811c
Compare
Totktonada
changed the title
|
fixed! |
|
tarantool-2.4 and tarantool-2.5 fails are due to tarantool/tarantool#4507, it is unrelated. I'll fix soon. |
Fixed in PR #256, but the next CI fail reveals (see comments). I'll leave CI red for a while: don't have enough attentiveness tonight :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should help to fix javadoc issues much early then during mvn release:clean release:prepare.
Fixes #244