Support tarantool #1

usenko-timur · 2022-08-04T15:10:08Z

No description provided.

extension/extension.ts

.vscode/launch.json

extension/luaDebugSession.ts

package-lock.json

tsafin

За исключением пары замечаний про хардкод констант (которые не блокирующие, и можно вернуться к этому позже) всё остальное LGTM.

У нас есть возможность отлаживать встроенные модули в Тарантуле. Woohoo!

.github/workflows/bundle.yml

- Conditional call to tarantool.debug.getsources() (to make it work with unpatched tarantool executables also);

Conditional tarantool.debug.getsources() usage

tsafin · 2022-11-21T13:08:45Z

README.md

-
-!["lua-local.interpreter": "lua5.1"](resources/settings.png '"lua-local.interpreter": "lua5.1"')
+### Tarantool Lua Stand-Alone Interpreter
+To debug a Lua program using a stand-alone interpreter, set `lua-tarantool.interpreter` in your user or workspace settings.


I assume we now should refer to lua-tarantool.tarantool parameter here;

I'd rephrase it slightly (t omake it more Tarantool specific), e.g:

"To debug a Lua program using particular Tarantool executable, set lua-tarantool.tarantool in your user or workspace settings."

tsafin · 2022-11-21T13:10:32Z

README.md

-```lua
-require("lldebugger").start()
-```
-Note that the path to `lldebugger` will automatically be appended to the `LUA_PATH` environment variable, so it can be found by Lua.


I'd keep this information elsewhere (at the end of standard configuration part?):
"Note that the path to lldebugger will automatically be appended to the LUA_PATH environment variable, so it can be found by Lua."

tsafin · 2022-11-21T13:11:58Z

extension/luaDebugSession.ts

@@ -213,7 +213,7 @@ export class LuaDebugSession extends LoggingDebugSession {
            env: Object.assign({}, process.env),
            cwd,
            shell: true,
-            detached: process.platform !== "win32"
+            detached: true,


I'd also cleanup usage of detached as it's always true now.

tsafin · 2022-11-21T13:14:54Z

extension/luaDebugSession.ts

+            : "";
+        const processArgs: string[] = [
+            "-e",
+            "\"require 'strict'.off()\"",


Soon after our discussion I've realized that we do not need to mess with strict mode at all (even under debugging), as we do not use any global variable anymore (as it used to be before), but rather simple require "tarantool".debug which is perfectly compatible with strict mode.

i.e. those 2 lines adding call to "require 'strict'.off()" are not needed.

Looks like we do need to have it enabled as there is rawlen used

tsafin · 2022-11-21T13:15:26Z

package.json

@@ -20,9 +20,6 @@
    "tstl",
    "typescripttolua",
    "typescript-to-lua",
-    "love",


tsafin

Almost there (with a few documentation changes, and single, small code tweek)

usenko-timur self-assigned this Aug 4, 2022