Skip to content

tarantool-php with php 7.4 #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheFatal opened this issue Feb 12, 2020 · 2 comments
Closed

tarantool-php with php 7.4 #150

TheFatal opened this issue Feb 12, 2020 · 2 comments
Assignees

Comments

@TheFatal
Copy link

hey guys, can anyone build it with php 7.4 ? im gettin error with both master and 7-v2 versions

Makefile:191: recipe for target 'src/tarantool.lo' failed
make[1]: *** [src/tarantool.lo] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: make -j1 returned exit code 2
debian/rules:22: recipe for target 'binary' failed
make: *** [binary] Error 2
This was referenced Mar 23, 2020
@Totktonada Totktonada added this to the Support PHP 7.* milestone Mar 23, 2020
@Totktonada
Copy link
Member

After fixing #139 the connector successfully built on php 7.4.

I look over the list of the internal PHP API changes and it seems the only this we should consider is the following:

s. Typed references support

See the following links:

@Totktonada Totktonada self-assigned this Mar 23, 2020
@Totktonada
Copy link
Member

From https://wiki.php.net/rfc/typed_properties_v2#assignments_to_references:

Places where such replacements are necessary can be detected by searching for z/, ZEND_PARAM_ZVAL_DEREF and ZVAL_DEREF in the extension.

It seems we don't affected here: we don't write to arguments that are passed by reference, we don't use z/ and *ZVAL_DEREF.

So no work remains here. Support of PHP 7.4 will be enabled in the scope of the umbrella task #137.

Totktonada added a commit that referenced this issue Mar 24, 2020
After fixes for PHP 7.3 everything also works for PHP 7.4 (see #150).

We just need to enable PHP 7.4 in CI.
Totktonada added a commit that referenced this issue Mar 25, 2020
After fixes for PHP 7.3 everything also works for PHP 7.4 (see #150).

We just need to enable PHP 7.4 in CI.
Totktonada added a commit that referenced this issue Mar 26, 2020
After fixes for PHP 7.3 everything also works for PHP 7.4 (see #150).

We just need to enable PHP 7.4 in CI.
Totktonada added a commit that referenced this issue Mar 28, 2020
After fixes for PHP 7.3 everything also works for PHP 7.4 (see #150).

We just need to enable PHP 7.4 in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants