Skip to content

Tarantool exceptions enhancement: custom classes, lua traceback #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zaglex opened this issue Jun 6, 2016 · 2 comments
Closed

Tarantool exceptions enhancement: custom classes, lua traceback #88

zaglex opened this issue Jun 6, 2016 · 2 comments
Assignees
Labels
feature A new functionality

Comments

@zaglex
Copy link

zaglex commented Jun 6, 2016

It would be great to improve exceptions thrown by Tarantool:

  1. Use separate class, e.g. TarantoolException, or even hierarchy of classes.
  2. For "query errors" you could pass error code as $code parameter, so that it would be available through $exception->getCode().
  3. Save lua-traceback to some custom field of your exception object. Currently we should use xpcall with debug.traceback(), and return traceback manually.
@bigbes
Copy link
Contributor

bigbes commented Jun 6, 2016

1 and 2 - It's planned (and partially implemented) on PHP7 branch. Please, look at #36
3 - It must be implemented on Tarantool's side. Please, look at tarantool/tarantool#677

@bigbes bigbes added the feature A new functionality label Jun 22, 2016
@bigbes bigbes self-assigned this Jun 23, 2016
@bigbes
Copy link
Contributor

bigbes commented Aug 1, 2016

1 and 2 - done on branch php7-v2.
3 - Please, file separate issue, or follow original ticket on Tarantool.

@bigbes bigbes closed this as completed Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new functionality
Projects
None yet
Development

No branches or pull requests

2 participants