Update 'use_unix_sockets_iproto' option for core = app tests #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
approved these changes
May 18, 2020
There was a problem hiding this comment.
LGTM. Just a couple of nits.
Nit: You describe the option as the new one in the commit message, it may be a bit misleading. It was added in e947b54 for 'core = tarantool' tests and updated here to support 'core = app' tests.
Part of Tarantool #4459
This is not linked with tarantool's issue. I suggest to use full URL.
Updated 'use_unix_sockets_iproto' option to support 'core = app' tests, which enabled unix sockets for iproto connections. It helped to handle the problem with 'Address already in use' error. Part of issue tarantool/tarantool#4459
avtikhon
force-pushed
the
avtikhon/unix_sockets_tap
branch
from
e1a7e92 to
6b04c1e
Compare
avtikhon
changed the title
avtikhon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update 'use_unix_sockets_iproto' for 'core = app'
Updated 'use_unix_sockets_iproto' option to support 'core = app'
tests, which enabled unix sockets for iproto connections. It helped
to handle the problem with 'Address already in use' error.
Part of issue tarantool/tarantool#4459