Skip to content

pretest_clean: add SQL built-in function UUID() #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2021

Conversation

ImeevMA
Copy link
Contributor

@ImeevMA ImeevMA commented May 27, 2021

This patch adds the built-in SQL function UUID() to the list of allowed
functions. This function is described in RFC "Consistent Lua/SQL types"
and will be added as part of issue tarantool/tarantool#5886.

Needed for tarantool/tarantool#5886.

This patch adds the built-in SQL function UUID() to the list of allowed
functions. This function is described in RFC "Consistent Lua/SQL types"
and will be added as part of issue tarantool/tarantool#5886.

Needed for tarantool/tarantool#5886.
@Totktonada Totktonada force-pushed the imeevma/gh-5886-add-sql-built-in-function-uuid branch from 81e9c2c to 2b3c557 Compare May 27, 2021 13:40
@Totktonada Totktonada changed the title pretest-clean: add SQL built-in function UUID() pretest_clean: add SQL built-in function UUID() May 27, 2021
@Totktonada
Copy link
Member

I made tiny fixup: pretest-clean -> pretest_clean (to use the same prefix as in previous commits).

Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@avtikhon avtikhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch seems clean and LGTM.

Copy link
Contributor

@VitaliyaIoffe VitaliyaIoffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Totktonada Totktonada merged commit 7ddaf6a into master May 28, 2021
@Totktonada Totktonada deleted the imeevma/gh-5886-add-sql-built-in-function-uuid branch May 28, 2021 09:34
Totktonada added a commit to tarantool/tarantool that referenced this pull request May 28, 2021
There are several updates in test-run:

* Unit testing and coverage collecting for test-run ([1]).
  (Plus a fixup for `--disable-schema-upgrade` for Python 3.5.)
* Allow to miss a timeout in test_run:wait_log(): it is 60 seconds by
  default ([2]).
* pretest_clean: add built-in `UUID()` SQL function ([3]).

[1]: tarantool/test-run#283
[2]: tarantool/test-run#306
[3]: tarantool/test-run#307
Totktonada added a commit to tarantool/tarantool that referenced this pull request May 28, 2021
There are several updates in test-run:

* Unit testing and coverage collecting for test-run ([1]).
  (Plus a fixup for `--disable-schema-upgrade` for Python 3.5.)
* Allow to miss a timeout in test_run:wait_log(): it is 60 seconds by
  default ([2]).
* pretest_clean: add built-in `UUID()` SQL function ([3]).

[1]: tarantool/test-run#283
[2]: tarantool/test-run#306
[3]: tarantool/test-run#307

(cherry picked from commit 0f44ede)
Totktonada added a commit to tarantool/tarantool that referenced this pull request May 28, 2021
There are several updates in test-run:

* Unit testing and coverage collecting for test-run ([1]).
  (Plus a fixup for `--disable-schema-upgrade` for Python 3.5.)
* Allow to miss a timeout in test_run:wait_log(): it is 60 seconds by
  default ([2]).
* pretest_clean: add built-in `UUID()` SQL function ([3]).

[1]: tarantool/test-run#283
[2]: tarantool/test-run#306
[3]: tarantool/test-run#307

(cherry picked from commit 0f44ede)
Totktonada added a commit to tarantool/tarantool that referenced this pull request May 28, 2021
There are several updates in test-run:

* Unit testing and coverage collecting for test-run ([1]).
  (Plus a fixup for `--disable-schema-upgrade` for Python 3.5.)
* Allow to miss a timeout in test_run:wait_log(): it is 60 seconds by
  default ([2]).
* pretest_clean: add built-in `UUID()` SQL function ([3]).

[1]: tarantool/test-run#283
[2]: tarantool/test-run#306
[3]: tarantool/test-run#307

(cherry picked from commit 0f44ede)
@Totktonada
Copy link
Member

Updated the test-run submodule in tarantool in the following commits: 2.9.0-45-g0f44ede23, 2.8.1-23-g1b632d36c, 2.7.2-18-g9221e0e28, 1.10.10-10-gbc8463d67.

avtikhon pushed a commit to avtikhon/tarantool that referenced this pull request Jun 1, 2021
There are several updates in test-run:

* Unit testing and coverage collecting for test-run ([1]).
  (Plus a fixup for `--disable-schema-upgrade` for Python 3.5.)
* Allow to miss a timeout in test_run:wait_log(): it is 60 seconds by
  default ([2]).
* pretest_clean: add built-in `UUID()` SQL function ([3]).

[1]: tarantool/test-run#283
[2]: tarantool/test-run#306
[3]: tarantool/test-run#307
avtikhon pushed a commit to avtikhon/tarantool that referenced this pull request Jun 1, 2021
There are several updates in test-run:

* Unit testing and coverage collecting for test-run ([1]).
  (Plus a fixup for `--disable-schema-upgrade` for Python 3.5.)
* Allow to miss a timeout in test_run:wait_log(): it is 60 seconds by
  default ([2]).
* pretest_clean: add built-in `UUID()` SQL function ([3]).

[1]: tarantool/test-run#283
[2]: tarantool/test-run#306
[3]: tarantool/test-run#307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants