Fail *.test.py tests in case of srv start errors #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a tarantool server failed to start when running *.test.py tests, the corresponding test was not considered by test-run as a failed test. As a result of that, log artifacts were not gathered by test-run. Now it is fixed. Fixes #333
ylobankov
force-pushed
the
ylobankov/handle-server-start-errors-in-py-tests
branch
from
6b9a413 to
b09dd5d
Compare
ylobankov
force-pushed
the
ylobankov/handle-server-start-errors-in-py-tests
branch
from
a4d0bcf to
658018b
Compare
Totktonada
reviewed
Jun 7, 2022
Totktonada
reviewed
Jun 7, 2022
Totktonada
approved these changes
Jun 7, 2022
Before:
[001] Worker "001_replication-py" cannot start tarantool server; the tasks will be ignored...
[001] The raised exception is '
[001] [Instance "master"] Failed to start
[001] ' of type '<class 'lib.tarantool_server.TarantoolStartError'>'.
[001] Worker "001_replication-py" received the following error:
[001] Traceback (most recent call last):
[001] File "/Users/y.lobankov/Workspace/tarantool/test-run/lib/worker.py", line 259, in __init__
[001] self.inspector = suite.start_server(self.server)
[001] File "/Users/y.lobankov/Workspace/tarantool/test-run/lib/test_suite.py", line 245, in start_server
[001] server.deploy(silent=False)
[001] File "/Users/y.lobankov/Workspace/tarantool/test-run/lib/tarantool_server.py", line 759, in deploy
[001] self.start(silent=silent, **kwargs)
[001] File "/Users/y.lobankov/Workspace/tarantool/test-run/lib/tarantool_server.py", line 886, in start
[001] self.wait_until_started(wait_load, deadline)
[001] File "/Users/y.lobankov/Workspace/tarantool/test-run/lib/tarantool_server.py", line 1118, in wait_until_started
[001] self.wait_load(deadline)
[001] File "/Users/y.lobankov/Workspace/tarantool/test-run/lib/tarantool_server.py", line 1102, in wait_load
[001] if not self.logfile_pos.seek_wait(msg, p, self.name, deadline):
[001] File "/Users/y.lobankov/Workspace/tarantool/test-run/lib/tarantool_server.py", line 469, in seek_wait
[001] raise TarantoolStartError(name)
[001] lib.tarantool_server.TarantoolStartError:
[001] [Instance "master"] Failed to start
[001]
[001]
After:
[001] Worker "001_replication-py" cannot start tarantool server; the tasks will be ignored...
[001] The raised exception is '[Instance "master"] Failed to start' of type '<class 'lib.tarantool_server.TarantoolStartError'>'.
[001] Worker "001_replication-py" received the following error:
[001] Traceback (most recent call last):
[001] File "/Users/y.lobankov/Workspace/tarantool/test-run/lib/worker.py", line 259, in __init__
[001] self.inspector = suite.start_server(self.server)
[001] File "/Users/y.lobankov/Workspace/tarantool/test-run/lib/test_suite.py", line 245, in start_server
[001] server.deploy(silent=False)
[001] File "/Users/y.lobankov/Workspace/tarantool/test-run/lib/tarantool_server.py", line 777, in deploy
[001] self.start(silent=silent, **kwargs)
[001] File "/Users/y.lobankov/Workspace/tarantool/test-run/lib/tarantool_server.py", line 904, in start
[001] self.wait_until_started(wait_load, deadline)
[001] File "/Users/y.lobankov/Workspace/tarantool/test-run/lib/tarantool_server.py", line 1136, in wait_until_started
[001] self.wait_load(deadline)
[001] File "/Users/y.lobankov/Workspace/tarantool/test-run/lib/tarantool_server.py", line 1120, in wait_load
[001] if not self.logfile_pos.seek_wait(msg, p, self.name, deadline):
[001] File "/Users/y.lobankov/Workspace/tarantool/test-run/lib/tarantool_server.py", line 481, in seek_wait
[001] raise TarantoolStartError(name)
[001] lib.tarantool_server.TarantoolStartError:
[001] [Instance "master"] Failed to start
ylobankov
force-pushed
the
ylobankov/handle-server-start-errors-in-py-tests
branch
from
658018b to
32af427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a tarantool server failed to start when running *.test.py tests,
the corresponding test was not considered by test-run as a failed test.
As a result of that, log artifacts were not gathered by test-run. Now
it is fixed.
Fixes #333