Add support for environment variable TARANTOOL_REGISTRY #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vasilevichra
force-pushed
the
registry
branch
3 times, most recently
from
afd23c4 to
e803182
Compare
|
|
ArtDu
reviewed
May 6, 2024
src/main/java/org/testcontainers/containers/TarantoolImageParams.java
Outdated
Show resolved
Hide resolved
dkasimovskiy
requested changes
May 6, 2024
vasilevichra
force-pushed
the
registry
branch
5 times, most recently
from
3919f39 to
c04a08b
Compare
|
|
|
ArtDu
reviewed
May 6, 2024
src/main/java/org/testcontainers/containers/TarantoolContainer.java
Outdated
Show resolved
Hide resolved
dkasimovskiy
requested changes
May 6, 2024
...t/java/org/testcontainers/containers/TarantoolCartridgeBootstrapFromLuaWithFixedPortsIT.java
Show resolved
Hide resolved
src/main/resources/Dockerfile
Outdated
| FROM tarantool/tarantool:${TARANTOOL_VERSION} AS cartridge-base | ||
| ARG TARANTOOL_VERSION="2.11.2-ubuntu20.04" | ||
| ARG IMAGE_NAME="tarantool/tarantool:$TARANTOOL_VERSION" | ||
| FROM $IMAGE_NAME AS cartridge-base |
There was a problem hiding this comment.
Suggested change
| FROM $IMAGE_NAME AS cartridge-base | |
| FROM {$IMAGE}:${TARANTOOL_VERSION} AS cartridge-base |
There was a problem hiding this comment.
Это будет не единообразно для каких-нибудь centos:7
There was a problem hiding this comment.
По-хорошему TARANTOOL_VERSION нужно переименовать в TAG или TAG_NAME, но это ломает обратную совместимость.
С другой стороны, переменная $IMAGE не должна содержать в себе TAG, если следовать документации dockerfile
src/main/java/org/testcontainers/containers/TarantoolContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/testcontainers/containers/TarantoolContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/testcontainers/containers/TarantoolContainer.java
Outdated
Show resolved
Hide resolved
Ага, видел. Их базовые тянут откуда-то. Не нашёл способа, как на них можно повлиять. А может быть это какой-нибудь кэш. |
|
|
Странно то, я сейчас загрузил все эти 3 имаджа, но другие нет когда вызываешь docker images. 
|
ArtDu
reviewed
May 6, 2024
|
dkasimovskiy
approved these changes
May 7, 2024
ArtDu
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't forgotten about:
Related issues: