Skip to content

tt cartridge #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LeonidVas opened this issue Mar 31, 2022 · 0 comments · Fixed by #72
Closed

tt cartridge #34

LeonidVas opened this issue Mar 31, 2022 · 0 comments · Fixed by #72
Assignees
@0x501D

Comments

@LeonidVas
Copy link
Contributor

LeonidVas commented Mar 31, 2022 •
edited
Loading

To work with the "cartridge" we want to reuse the https://github.com/tarantool/cartridge-cli module, except the following commands:

  • start
  • stop
  • status
  • connect

and probably:

  • build
  • pack
  • create

The following implementation is suggested:
Add "cartridge-cli" to "tt" as a submodule with some wrapper that will mask excluded commands and pass others. Exceptions must also be taken into account for the "help" command.

Commands:

  • start
  • stop
  • status
  • connect
    must be updated in this task to support "cartridge" functionality.
@LeonidVas LeonidVas added 8sp and removed 8sp labels Mar 31, 2022
@Totktonada Totktonada added teamE and removed teamE labels Mar 31, 2022
@0x501D 0x501D mentioned this issue Jun 19, 2022
Closed
0x501D added a commit that referenced this issue Jun 19, 2022
@0x501D
build: add cartridge-cli submodule
fa8f71f 
This patchset adds cartridge-cli commands to tt:
*  admin
*  bench
*  build
*  clean
*  create
*  failover
*  pack
*  repair
*  replicasets

Closes #34
0x501D added a commit that referenced this issue Jun 19, 2022
@0x501D
tt: integrate cartridge cli
6924ae7 
Cartridge-cli must be patched in order to connect to tt cobra commands
tree. Also before build tt we must generate all cartridge-cli codegen
files.

Follow up #34
0x501D added a commit that referenced this issue Jun 19, 2022
@0x501D
cartridge: fix help for long commands.
0314fef 
Some long commands from cartridge-cli does not fit in tt help logic and tt
raisies nil pointer dereference error.

Follow up #34
0x501D added a commit that referenced this issue Jun 19, 2022
@0x501D
build: bump go version
5231da4 
Cartridge-cli needs golang version >= 1.18

Follow up #34
@0x501D 0x501D mentioned this issue Jun 19, 2022
Merged
0x501D added a commit that referenced this issue Jun 21, 2022
@0x501D
build: bump go version
43a1d8c 
Cartridge-cli needs golang version >= 1.18

Part of #34
0x501D added a commit that referenced this issue Jun 21, 2022
@0x501D
build: add cartridge-cli submodule
3708d11 
Part of #34
0x501D added a commit that referenced this issue Jun 21, 2022
@0x501D
tt: integrate cartridge cli
6d8f66d 
This patchset adds cartridge-cli commands to tt:
*  admin
*  bench
*  build
*  create
*  failover
*  pack
*  repair
*  replicasets

Cartridge-cli must be patched in order to connect to tt cobra commands
tree. Also before build tt we must generate all cartridge-cli codegen
files.

Closes #34
0x501D added a commit that referenced this issue Jun 21, 2022
@0x501D
help: fix help for long commands.
f4d578d 
Some long commands from cartridge-cli does not fit in tt help logic and tt
raisies nil pointer dereference error.

Follow up #34
0x501D added a commit that referenced this issue Jun 21, 2022
@0x501D
tt: integrate cartridge cli
779f7b4 
This patchset adds cartridge-cli commands to tt:
*  admin
*  bench
*  build
*  create
*  failover
*  pack
*  repair
*  replicasets

Cartridge-cli must be patched in order to connect to tt cobra commands
tree. Also before build tt we must generate all cartridge-cli codegen
files.

Closes #34
0x501D added a commit that referenced this issue Jun 21, 2022
@0x501D
help: fix help for long commands.
3f7d294 
Some long commands from cartridge-cli does not fit in tt help logic and tt
raisies nil pointer dereference error.

Follow up #34
LeonidVas pushed a commit that referenced this issue Jun 21, 2022
@0x501D @LeonidVas
build: bump go version
e9563f3 
Cartridge-cli needs golang version >= 1.18

Part of #34
LeonidVas pushed a commit that referenced this issue Jun 21, 2022
@0x501D @LeonidVas
build: add cartridge-cli submodule
313ecf9 
Part of #34
LeonidVas pushed a commit that referenced this issue Jun 21, 2022
@0x501D @LeonidVas
tt: integrate cartridge cli
6159ee6 
This patchset adds cartridge-cli commands to tt:
*  admin
*  bench
*  build
*  create
*  failover
*  pack
*  repair
*  replicasets

Cartridge-cli must be patched in order to connect to tt cobra commands
tree. Also before build tt we must generate all cartridge-cli codegen
files.

Closes #34
LeonidVas pushed a commit that referenced this issue Jun 21, 2022
@0x501D @LeonidVas
help: fix help for long commands.
6df49ee 
Some long commands from cartridge-cli does not fit in tt help logic and tt
raisies nil pointer dereference error.

Follow up #34
@andreyaksenov andreyaksenov mentioned this issue Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x501D 0x501D

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tt cartridge tarantool/tt
3 participants
@Totktonada @0x501D @LeonidVas