Skip to content

install: added support install TCM #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 15, 2025
Merged

Conversation

dmyger
Copy link
Collaborator

@dmyger dmyger commented Apr 30, 2025

This commit adds the ability to install Tarantool cluster manager (TCM),
using the command tt install tcm. The TCM installation process is
similar to the installation of Tarantool EE.

@TarantoolBot
Title: added tt install tcm

The command searches for the specified version and installs it.
If no version is specified, the latest TCM version will be installed.
A list of available TCM versions can be obtained using the
tt search tcm command.

Usage Example:

tt install tcm 1.2.3-0-geae7e7d49

I didn't forget about (remove if it is not applicable):

  • Well-written commit messages (see documentation how to write a commit message)
  • Don't forget about TarantoolBot in a commit message (see example)
  • Tests (see documentation for a testing package)
  • Changelog (see documentation for changelog format)
  • Documentation (see documentation for documentation style guide)

Closes #TNTP-1095

@dmyger dmyger force-pushed the dmyger/tntp-1095_tcm_install branch 4 times, most recently from 43fcd4d to 57f171f Compare May 7, 2025 19:30
@dmyger dmyger marked this pull request as ready for review May 7, 2025 19:32
@dmyger dmyger added the full-ci Enables full ci tests label May 7, 2025
@dmyger dmyger force-pushed the dmyger/tntp-1095_tcm_install branch from 57f171f to c6687a6 Compare May 7, 2025 21:38
@dmyger dmyger force-pushed the dmyger/tntp-1095_tcm_install branch 9 times, most recently from cae4a59 to 51c77de Compare May 13, 2025 09:03
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the non-critical comments below.

@dmyger dmyger requested a review from patapenka-alexey May 14, 2025 10:46
dmyger added 5 commits May 14, 2025 16:08
The representation of program types as plain strings has been refactored
into a strongly-typed enum. Methods were added to retrieve string
representations matching the previous values and to obtain
the corresponding executable file name for each program type.

Part of #TNTP-1095
Fixed an issue where running the TcS server in the current directory
created database files that were not removed after tests finished.
This occasionally caused problems when running subsequent tests.

The solution was to use the testing wrapper for TcS
provided by the go-tarantool library.

Part of #TNTP-1095
This commit adds the ability to install Tarantool cluster manager (TCM),
using the command `tt install tcm`. The TCM installation process is
similar to the installation of Tarantool EE.

@TarantoolBot
Title: added `tt install tcm`

The command searches for the specified version and installs it.
If no version is specified, the latest TCM version will be installed.
A list of available TCM versions can be obtained using the
`tt search tcm` command.

**Usage Example**:
```bash
tt install tcm 1.2.3-0-geae7e7d49
```

Closes #TNTP-1095
The handling of User Credentials for connecting to EE has been moved
to the `lib/connect` package. This had little to do with
the installation process, and secondly it created a dependency include
loop between `cli/install_ee` and `cli/search`.

Part of #TNTP-1095
@dmyger dmyger force-pushed the dmyger/tntp-1095_tcm_install branch from 51c77de to 622b4bc Compare May 14, 2025 13:57
@dmyger dmyger force-pushed the dmyger/tntp-1095_tcm_install branch from 622b4bc to 58570fb Compare May 14, 2025 14:20
@dmyger dmyger requested a review from oleg-jukovec May 14, 2025 14:21
@dmyger dmyger merged commit 40507ae into master May 15, 2025
24 checks passed
@dmyger dmyger deleted the dmyger/tntp-1095_tcm_install branch May 15, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Enables full ci tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants