-
Notifications
You must be signed in to change notification settings - Fork 15
tt: added tt create module #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. It would be also nice to have some description how to use it for users, but I don'y know if we have some place to leave the instructions for this. I will leave more feedback for the code later.
It is also accepted (here) to mark a commit with |
4d2d31d
to
6bce831
Compare
Examples are added to the help:
|
07cbb52
to
58babaa
Compare
58babaa
to
465b1a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0804ea2
to
b6e6214
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
upd. after rebase :)
6547f5b
to
8a0094d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. I briefly reviewed the patch and plan to explore it further. The idea of using the "chain of responsibility" pattern looks interesting.
I have several comments:
- "Update cartridge-cli submodule" -> "cartridge cli: bump new version".
- It would be nice to add reasons to bump the new version to commit message. I think this was done not just for fun.
bb9c5b5
to
b496f70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thank you for the patchset.
Patchset already has two LGTM so I did not see it in detail, rather an introductory one.
I expect the following PR with a description of the functionality in the README and with examples in https://github.com/tarantool/tt/blob/master/doc/examples.rst
Fix typos in code and comment
-> Commit title should be of a form <subsystem>: <description>
(https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message)
This is a big and good work, and I believe that in the future you will split the functionality into several commits. Right now it's very difficult to review.
See comments bellow (some of them may be irrelevant because your update happened in the middle of my review.).
Perhaps some of the questions are easier to discuss by voice. So ping if you need. |
b496f70
to
d5440fa
Compare
Added module allows a user to create tarantool application from a template. go text/template engine is used for template instantiation by default. Closes #12
d5440fa
to
46070a1
Compare
tt create allows a user to create tarantool application from a template.
tt create accepts template name as a parameter and searches for it in
of current environment. Found template will be used for application creation.
'basic' is the default template name.
Supported flags:
Invocation example:
tt create --var name=name --name=app1 --non-interactive
Closes #12