Upgrade httpx library and switch test mocks to match_json #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main goal: Upgrade httpx to latest supported version. Details: - Switched test mocks from match_content (bytes) to match_json in test_scope.py and test_sdk_primatives.py. - This is necessary because httpx and pytest-httpx upgrades can change JSON serialization (whitespace, key order), causing byte-level matching to fail even when the data is correct. - match_json is robust to formatting and key order, ensuring tests remain stable after dependency upgrades.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal: Upgrade httpx to latest supported version as I requested here #36.
Details:
PS: thanks copilot for making the hard work of this PR.