feat(core): optimize raw payload in event system, closes #13405 #14269
Conversation
Package Changes Through 1259ca5There are 9 changes which include @tauri-apps/api with minor, tauri-cli with minor, tauri-utils with minor, tauri-runtime-wry with minor, tauri-runtime with minor, tauri with minor, tauri-bundler with minor, @tauri-apps/cli with minor, tauri-macros with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
we might need to introduce new JS functions too.. this actually breaks the data received on the backend side if you are sending array buffers using the current event system (which serializes it) |
| * | ||
| * @since 2.10.0 | ||
| */ | ||
| async function emitTo2<T>( |
There was a problem hiding this comment.
Is this new function necessary? We're sending the same command to our rust side anyways no (as long as we handle both cases in rust side which I assume it's already the case when are calling it like this, it should be backward compatible)?
There was a problem hiding this comment.
I'm not sure I get it, isn't the new emit2 code the same as emit in the previous revisions in the PR?
| EmitPayload::Str(payload) => EmitArgs::new_str(event, payload)?, | ||
| }; | ||
| EmitPayload::Str(payload) => EmitArgs::new_str(event, payload), | ||
| EmitPayload::Binary(payload) => { |
There was a problem hiding this comment.
This should be done with the same check (size check instead of binary type check) we did for the channel implementation or it will actually slow down smaller payloads
2 participants
leverages the IPC to send raw data through the event system (similar approach to how channels send raw data through - associate data with an ID, and eval a script that fetches the actual data using the IPC to avoid serialization).
The JS API automatically uses the optimized interface, but Rust emitters should use
Emitter::emit_rawandEmitter::emit_raw_toto emit raw payloads, and readEvent::payload_rawinstead ofEvent::payload.Ideally we would change types a bit to support both JSON and raw payloads, but we're introducing new methods to avoid breaking changes.