-
-
Notifications
You must be signed in to change notification settings - Fork 369
Apply Version Updates From Current Changes #1578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3d1a463
to
61967d3
Compare
1f73292
to
2b02067
Compare
Hi, when will we merge this PR? I noticed it has been open for quite a while. Once it's merged, we can continue moving forward with tauri-apps/tauri#13848 and tauri-apps/tauri#13661 😇. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe nobody care about typo's but I'm doing, so fix it and maybe it will got taken to be merged.
files that you need to include in your Android application for wry to function properly. | ||
- `WRY_ANDROID_PACKAGE`: which is the reversed domain name of your android project and the app name in snake_case, for example, `com.wry.example.wry_app` | ||
- `WRY_ANDROID_LIBRARY`: for example, if your cargo project has a lib name `wry_app`, it will generate `libwry_app.so` so you set this env var to `wry_app` | ||
- `WRY_ANDROID_LIBRARY`: for example, if your cargo project has a lib name `wry_app`, it will generate `libwry_app.so` so you se this env var to `wry_app` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
[](https://opencollective.com/tauri) | ||
|
||
Wry is a cross-platform WebView rendering library. | ||
Wry is a Cross-platform WebView rendering library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
If this feels overwhelming, you can just use the preconfigured template from [`cargo-mobile2`](https://github.com/tauri-apps/cargo-mobile2). | ||
|
||
For more information, check out [MOBILE.md](https://github.com/tauri-apps/wry/blob/dev/MOBILE.md). | ||
For more inforamtion, checkout [MOBILE.md](https://github.com/tauri-apps/wry/blob/dev/MOBILE.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
- `protocol` (default): Enables [`WebViewBuilder::with_custom_protocol`] to define custom URL scheme for handling tasks like | ||
loading assets. | ||
- `drag-drop` (default): Enables [`WebViewBuilder::with_drag_drop_handler`] to control the behavior when there are files | ||
- `drag-drop` (default): Enables [`WebViewBuilder::with_drag_drop_handler`] to control the behaviour when there are files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
interacting with the window. | ||
- `devtools`: Enables devtools on release builds. Devtools are always enabled in debug builds. | ||
On **macOS**, enabling devtools, requires calling private APIs so you should not enable this flag in release | ||
On **macOS**, enabling devtools, requires calling private apis so you should not enable this flag in release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
2b02067
to
415d8a4
Compare
holy shit why is it tripping like that. i'll delete the branch and see if it can properly recreate it. thanks for noticing this. |
Version Updates
Merging this PR will release new versions of the following packages based on your change files.
wry
[0.52.2]
WebViewBuilder::with_limit_navigations_to_app_bound_domains
#1588 by @zphrs) AddWebViewBuilder::with_limit_navigations_to_app_bound_domains
only on iOS.Function is a no-op if iOS version is less than iOS 14.
WebView::set_cookie
andWebView::delete_cookie
#1569 by @WSH032) AddWebView::set_cookie
andWebView::delete_cookie
APIs.download_started_handler
will now get the correct suggested destination path.