Scopes: Use relative encoding for column, absolute for callsite #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbenl
approved these changes
Mar 31, 2025
szuend
added a commit
to ChromeDevTools/source-map-scopes-codec
that referenced
this pull request
Apr 1, 2025
Part of aligning the imlpementation with tc39/ecma426#188.
szuend
added a commit
to ChromeDevTools/source-map-scopes-codec
that referenced
this pull request
Apr 1, 2025
Part of aligning with tc39/ecma426#188.
szuend
added a commit
to ChromeDevTools/source-map-scopes-codec
that referenced
this pull request
Apr 1, 2025
Last bit to align with tc39/ecma426#188.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the changes to "decoding state" as discussed in the meeting of 2025-03-27:
original_scope_startandoriginal_scope_endcolumn is relative if the previous item was on the same line.generated_range_callsitenow uses absolute unsigned values, as we don't know if there is an actual benefit to encoding callsites relative.Once this PR and #187 have landed, I'll update https://jsr.io/@chrome-devtools/source-map-scopes-codec to reflect the changes.