Add test for importing a succesfully evaluated module of an async errored SCC #4500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
force-pushed
the
test-module-scc-evaluated-fail-async
branch
from
4ed5804 to
5db35d2
Compare
nicolo-ribaudo
commented
May 22, 2025
There was a problem hiding this comment.
The test is failing on CI with this error:
FAIL test/language/module-code/top-level-await/evaluated-dep-from-async-errored-scc.js (default)
asyncTest called without async flag
FAIL test/language/module-code/top-level-await/evaluated-dep-from-async-errored-scc.js (strict mode)
asyncTest called without async flag
What am I doing wrong?
nicolo-ribaudo
force-pushed
the
test-module-scc-evaluated-fail-async
branch
from
5db35d2 to
0268c14
Compare
nicolo-ribaudo
force-pushed
the
test-module-scc-evaluated-fail-async
branch
from
0268c14 to
3586912
Compare
This was referenced May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test for tc39/ecma262#3584 (comment), for which we currently do not have any test262 coverage.
cc @guybedford