-
Notifications
You must be signed in to change notification settings - Fork 42
Catch #[no_mangle]
#128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch #[no_mangle]
#128
Conversation
88b2dd9
to
e708853
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in general this is fine, code wise. It definitely needs some code comments/commentary about what's happening, why it works, the possible problems it prevents, etc, etc.
Move some comments onto types so they show up with cargo doc --document-private-items and make sure those docs look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ship it!
Thanks for the clarifications offline, @workingjubilee. I know I can be dense sometimes. I'd like to enshrine them here:
|
This PR adds code sufficient to catch the usage of
#[no_mangle]
. Note that deploying PL/Rust with the given Rust toolchain currently indicated by ourrust-toolchain.toml
will not in fact catch#[link_section]
, despite the branch name. That requires an upgrade to a more recent version of Rust, which is incompatible with use withpostgrestd
without patching that, which is itself incompatible with other requirements that have been communicated to me.