Skip to content

Testing #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 523 commits into
base: main
Choose a base branch
from
Open

Testing #8

wants to merge 523 commits into from

Conversation

avb-is-me
Copy link

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

jed326 and others added 30 commits April 28, 2025 10:45
…queue size configurable (#18088)

---------

Signed-off-by: Varun Bharadwaj <[email protected]>
(cherry picked from commit c2f323a)

Signed-off-by: Rajat Gupta <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rajat Gupta <[email protected]>
Signed-off-by: Rajat Gupta <[email protected]>
Co-authored-by: Rajat Gupta <[email protected]>
These are some of the most frequent offenders for failing builds. All
have existing issues open for tracking their fixes.

Signed-off-by: Andrew Ross <[email protected]>
I believe the test tear down is racing with the thread leak detector
because the `shutdown()` method does not actually wait for all the
threads to stop. The fix here is to use `ThreadPool::terminate` which
does the proper shutdown and ensures are threads are stopped before
returning from the tearDown method.

Signed-off-by: Andrew Ross <[email protected]>
* Fix flaky TransportMultiSearchActionTests.testCancellation

Signed-off-by: kkewwei <[email protected]>
Signed-off-by: kkewwei <[email protected]>

* Fix typo

Signed-off-by: Andrew Ross <[email protected]>

---------

Signed-off-by: kkewwei <[email protected]>
Signed-off-by: kkewwei <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
…ugins/ingest-attachment (#18101)

* Bump org.apache.commons:commons-collections4

Bumps org.apache.commons:commons-collections4 from 4.4 to 4.5.0.

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-collections4
  dependency-version: 4.5.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updating SHAs

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This appears to be unused and was only relevant for very old versions of
Elasticsearch.

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit 33b88a2)

Signed-off-by: Rajat Gupta <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rajat Gupta <[email protected]>
I believe it's a mistake to assume that an operation will take more than
zero milliseconds. We don't necessarily know the resolution of the
clocks on the test machines, and a sufficently fast download in the test
environment can be truncated to zero millis.

Signed-off-by: Andrew Ross <[email protected]>
Allows removal of the separate maintainer check workflow

Signed-off-by: Peter Nied <[email protected]>
* Fix object field exists query

Signed-off-by: panguixin <[email protected]>

* catch uoe

Signed-off-by: panguixin <[email protected]>

* changelog

Signed-off-by: panguixin <[email protected]>

---------

Signed-off-by: panguixin <[email protected]>
Signed-off-by: Marc Handalian <[email protected]>
Co-authored-by: Marc Handalian <[email protected]>
(cherry picked from commit 47f9bdb)

Signed-off-by: Rajat Gupta <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rajat Gupta <[email protected]>
neuenfeldttj and others added 30 commits July 1, 2025 09:04
* copied from other branch, ready for pr

Signed-off-by: TJ Neuenfeldt <[email protected]>

* cleanup from merging

Signed-off-by: TJ Neuenfeldt <[email protected]>

* another spotless apply and fixed breaking change

Signed-off-by: TJ Neuenfeldt <[email protected]>

* another spotlessApply

Signed-off-by: TJ Neuenfeldt <[email protected]>

* forgot to change back concurrent agg stuff

Signed-off-by: TJ Neuenfeldt <[email protected]>

* forgot to spotless after prev fix

Signed-off-by: TJ Neuenfeldt <[email protected]>

* added more unit tests for coverage

Signed-off-by: TJ Neuenfeldt <[email protected]>

* changed to supplier, removed timer ctors

Signed-off-by: TJ Neuenfeldt <[email protected]>

* made feedback changes

Signed-off-by: TJ Neuenfeldt <[email protected]>

* forgot javadoc for new class

Signed-off-by: TJ Neuenfeldt <[email protected]>

* forgot to revert name to toString

Signed-off-by: TJ Neuenfeldt <[email protected]>

* fix count check in concurrentquerypb

Signed-off-by: TJ Neuenfeldt <[email protected]>

* unmodifiable map add

Signed-off-by: TJ Neuenfeldt <[email protected]>

---------

Signed-off-by: TJ Neuenfeldt <[email protected]>
Signed-off-by: TJ Neuenfeldt <[email protected]>
… for Regexp queries introduced in OpenSearch 3.0 (#18640)

* FIx ~ bug

Signed-off-by: Prudhvi Godithi <[email protected]>

* Update changelog

Signed-off-by: Prudhvi Godithi <[email protected]>

---------

Signed-off-by: Prudhvi Godithi <[email protected]>
)

---------

Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Co-authored-by: Ankit Jain <[email protected]>
* Fix bug in replication lag computation.

This change fixes a bug with replication lag computation to correctly use epoch reference point with Instant.now() and DateUtils.
This change also fixes pruning logic to correctly remove the latest synced to checkpoint from tracking.  Previously we would only
prune up to the latest.  This ensures that when a new checkpoint is eventually received we aren't incorrectly computing lag from the synced-to checkpoint.

Signed-off-by: Marc Handalian <[email protected]>

* add changelog entry

Signed-off-by: Marc Handalian <[email protected]>

* Fix flaky test to hardcode time lag between checkpoint arrival.

Signed-off-by: Marc Handalian <[email protected]>

---------

Signed-off-by: Marc Handalian <[email protected]>
…rContext in QueryPhase (#18637)

* Initial Commit

Signed-off-by: Varun Jain <[email protected]>

* Javadocs

Signed-off-by: Varun Jain <[email protected]>

* Factory design pattern for QueryCollectorContextSpec

Signed-off-by: Varun Jain <[email protected]>

* Fixing Concurrent Segment Search

Signed-off-by: Varun Jain <[email protected]>

* Remove spec

Signed-off-by: Varun Jain <[email protected]>

* Renaming method

Signed-off-by: Varun Jain <[email protected]>

* Javadoc

Signed-off-by: Varun Jain <[email protected]>

* Removing support method from QueryCollectorContextSpecFactory

Signed-off-by: Varun Jain <[email protected]>

* Adding javadoc

Signed-off-by: Varun Jain <[email protected]>

* Add changelog

Signed-off-by: Varun Jain <[email protected]>

* Add experimentalAPI annotation

Signed-off-by: Varun Jain <[email protected]>

* remove redundant check from getQueryCollectorContextSpec method

Signed-off-by: Varun Jain <[email protected]>

* Add unit tests

Signed-off-by: Varun Jain <[email protected]>

* Remove Test annotation

Signed-off-by: Varun Jain <[email protected]>

* Reformatting

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
…/repository-azure (#18644)

* Bump com.azure:azure-storage-blob in /plugins/repository-azure

Bumps [com.azure:azure-storage-blob](https://github.com/Azure/azure-sdk-for-java) from 12.30.0 to 12.30.1.
- [Release notes](https://github.com/Azure/azure-sdk-for-java/releases)
- [Commits](Azure/azure-sdk-for-java@azure-storage-blob_12.30.0...azure-storage-blob_12.30.1)

---
updated-dependencies:
- dependency-name: com.azure:azure-storage-blob
  dependency-version: 12.30.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updating SHAs

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…18636)

* Fix checkpoint handling to prevent segment replication infinite loop

Signed-off-by: Ashish Singh <[email protected]>

* Modify existing test to verify code change behaviour

Signed-off-by: Ashish Singh <[email protected]>

---------

Signed-off-by: Ashish Singh <[email protected]>
* Extend approximation to other numeric types

Signed-off-by: Prudhvi Godithi <[email protected]>

* Fix basic tests

Signed-off-by: Prudhvi Godithi <[email protected]>

* Fix basic tests

Signed-off-by: Prudhvi Godithi <[email protected]>

* Add Parameterized tests for all numeric types

Signed-off-by: Prudhvi Godithi <[email protected]>

* Fix FieldSortIT

Signed-off-by: Prudhvi Godithi <[email protected]>

* Fix FieldSortIT

Signed-off-by: Prudhvi Godithi <[email protected]>

* Address comments

Signed-off-by: Prudhvi Godithi <[email protected]>

* Update tests and changelog

Signed-off-by: Prudhvi Godithi <[email protected]>

* Update tests and changelog

Signed-off-by: Prudhvi Godithi <[email protected]>

---------

Signed-off-by: Prudhvi Godithi <[email protected]>
Changes:
- Bump org.bouncycastle:bctls-fips from 2.0.19 to 2.0.20
- Bump org.bouncycastle:bcpkix-fips from 2.0.7 to 2.0.8
- Bump org.bouncycastle:bcpg-fips from 2.0.10 to 2.0.11
- Bump com.password4j:password4j from 1.8.2 to 1.8.3

Signed-off-by: Andrey Pleskach <[email protected]>
…mote store (#18686)

Signed-off-by: Gagan Singh Saini <[email protected]>
Co-authored-by: Gaurav Bafna <[email protected]>
* Added support for range version support in semver

Signed-off-by: Shruti Garg <[email protected]>

* Added test coverage for missing lines

Signed-off-by: Shruti Garg <[email protected]>

* Fixed for non reachable code line and tests

Signed-off-by: Shruti Garg <[email protected]>

---------

Signed-off-by: Shruti Garg <[email protected]>
…dfs-fixture (#18689)

* Bump com.squareup.okio:okio in /test/fixtures/hdfs-fixture

Bumps [com.squareup.okio:okio](https://github.com/square/okio) from 3.14.0 to 3.15.0.
- [Release notes](https://github.com/square/okio/releases)
- [Changelog](https://github.com/square/okio/blob/master/CHANGELOG.md)
- [Commits](square/okio@parent-3.14.0...parent-3.15.0)

---
updated-dependencies:
- dependency-name: com.squareup.okio:okio
  dependency-version: 3.15.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add Semantic Version field type mapper and extensive unit tests

Signed-off-by: Siddhant Deshmukh <[email protected]>

* Refactor SemanticVersionFieldMapper for flexible index, store, and doc_values support

Signed-off-by: Siddhant Deshmukh <[email protected]>

---------

Signed-off-by: Siddhant Deshmukh <[email protected]>
…y-azure (#18691)

* Bump com.azure:azure-core in /plugins/repository-azure

Bumps [com.azure:azure-core](https://github.com/Azure/azure-sdk-for-java) from 1.55.3 to 1.55.5.
- [Release notes](https://github.com/Azure/azure-sdk-for-java/releases)
- [Commits](Azure/azure-sdk-for-java@azure-core_1.55.3...azure-core_1.55.5)

---
updated-dependencies:
- dependency-name: com.azure:azure-core
  dependency-version: 1.55.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updating SHAs

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Exposing default codec from codec service

Signed-off-by: bharath-techie <[email protected]>

* addressing comments

Signed-off-by: bharath-techie <[email protected]>

---------

Signed-off-by: bharath-techie <[email protected]>
* Add Prudhvi Godithi (GH: prudhvigodithi) as a maintainer

Signed-off-by: Craig Perkins <[email protected]>

* Keep spaces

Signed-off-by: Craig Perkins <[email protected]>

* Fix spacing

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
…18697)

* Fix: Include named queries from rescore contexts in matched_queries array

- Modified QueryRescoreContext to store ParsedQuery instead of just Query
- Updated QueryRescorerBuilder to use context.toQuery() for capturing named queries
- Enhanced MatchedQueriesPhase to collect named queries from all rescore contexts
- Added comprehensive tests for both unit and REST API scenarios
- Resolves inconsistency with Elasticsearch behavior where rescore named queries were not surfaced
- Cleaned up unnecessary comments for better code readability

Signed-off-by: Girish Jeyakumar <[email protected]>

* Address maintainer feedback: update RescoreContext interface design

- Added parsedQuery() method to RescoreContext interface
- Added getParsedQueries() method to RescoreContext interface
- Updated QueryRescoreContext to override interface methods
- Removed instanceof check in MatchedQueriesPhase by using interface method
- Simplified assignment in QueryRescorerBuilder to one line

Signed-off-by: Girish Jeyakumar <[email protected]>

* Complete interface replacement: replace query() with parsedQuery() and getQueries() with getParsedQueries()

- Removed query() method from QueryRescoreContext
- Removed getQueries() method from RescoreContext interface
- Updated all callers to use parsedQuery().query() instead of query()
- Updated DfsPhase to use getParsedQueries() instead of getQueries()
- Updated QueryRescorer to use parsedQuery().query() for rescoring and explanations
- Updated QueryRescorerBuilderTests to use parsedQuery().query()
- This addresses the maintainer's feedback for a cleaner interface design

Signed-off-by: Girish Jeyakumar <[email protected]>

* Finalize interface design and move changelog entry to Added section

- Removed parsedQuery() method from RescoreContext base interface
- Renamed getParsedQuery() to parsedQuery() in QueryRescoreContext for consistency
- Updated all callers to use parsedQuery() method
- Moved changelog entry to 'Added' section (more appropriate than 'Fixed')
- Added proper imports for ParsedQuery to improve code readability
- All tests pass and code formatting is correct

Final interface design:
- RescoreContext: only getParsedQueries() (returns List<ParsedQuery>)
- QueryRescoreContext: parsedQuery() + getParsedQueries() override
- MatchedQueriesPhase: uses getParsedQueries().forEach() for clean iteration

This addresses all maintainer feedback from @mch2 and provides a clean,
well-tested implementation that surfaces named queries from rescore contexts
in the matched_queries array.

Signed-off-by: Girish Jeyakumar <[email protected]>

* Maintain backward compatibility for RescoreContext public API

- Restore getQueries() method for backward compatibility
- Add getParsedQueries() method for new functionality

Signed-off-by: Girish Jeyakumar <[email protected]>

* Fix mixed cluster test failure by updating skip version to 3.2.0

Signed-off-by: girish jeyakumar <[email protected]>

---------

Signed-off-by: Girish Jeyakumar <[email protected]>
Signed-off-by: girish jeyakumar <[email protected]>
Signed-off-by: Marc Handalian <[email protected]>
Co-authored-by: Girish Jeyakumar <[email protected]>
Co-authored-by: Marc Handalian <[email protected]>
* Some explicit transient gRPC deps are not the expected version.

grpc-netty-shaded:1.68.2 expects perfmark-api:0.27.0
guava:33.2.1-jre expects failureaccess:1.0.2

Signed-off-by: Finn Carroll <[email protected]>

* Update license shas.

Signed-off-by: Finn Carroll <[email protected]>

* Changelog.

Signed-off-by: Finn Carroll <[email protected]>

* Rebase changelog.

Signed-off-by: Finn Carroll <[email protected]>

---------

Signed-off-by: Finn Carroll <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.