Skip to content

PS2_KEY_LANG4 + 1 is not PS2_KEY_LANG5 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ludolpif opened this issue Mar 29, 2025 · 0 comments · May be fixed by #38
Open

PS2_KEY_LANG4 + 1 is not PS2_KEY_LANG5 #34

ludolpif opened this issue Mar 29, 2025 · 0 comments · May be fixed by #38

Comments

@ludolpif
Copy link

Hi,

By writing a function to test some PS2KeyMap mapping like:

  for ( uint16_t code = PS2_KEY_NUM; code <= PS2_KEY_LANG5; code++ ) {
    remapped = keymap.remapKey(code);
    printRemapped(code, remapped);
  }

I found a weird definition of PS_KEY_LANG5. 0x99 + 1 is 0x9A and not 0xA0.

#define PS2_KEY_LANG4       0X99
#define PS2_KEY_LANG5       0xA0

And "0x9A" isn't anywhere in PS2KeyAdvanced.h. Is it a mistake ?

Thanks for the great work on this lib !

Regards,
Ludovic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant