Skip to content

Use mocha for tests #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2019
Merged

Use mocha for tests #47

merged 1 commit into from
Nov 6, 2019

Conversation

lhchavez
Copy link
Contributor

This change adds support for Mocha in order to run all JavaScript tests
at once.

@lhchavez
Use mocha for tests
aa70628 
This change adds support for Mocha in order to run all JavaScript tests
at once.
@lhchavez lhchavez mentioned this pull request Oct 12, 2019
Open
@lhchavez lhchavez requested review from rroque98 and fvntr October 12, 2019 03:34
@lhchavez
Copy link
Contributor Author

lhchavez commented Nov 6, 2019

this has been open for a month with no objections. merging.

@lhchavez lhchavez merged commit e74872a into techqueria:master Nov 6, 2019
@lhchavez lhchavez deleted the mocha branch November 6, 2019 01:38
rroque98
rroque98 reviewed Nov 6, 2019
View reviewed changes
Copy link
Contributor

@rroque98 rroque98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay. I just reviewed the changes and it looks good. Thanks for adding the support for Mocha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fvntr fvntr Awaiting requested review from fvntr

1 more reviewer

@rroque98 rroque98 rroque98 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhchavez @rroque98