Use tags to assign responses to result list #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when asynchronously processing responses for a GetFeaturesBatch request (resulting in many individual GetFeature calls), we searched for the request object in the original request list to determine where to place the response in the response list, so as to maintain ordering. This is less efficient than it could be, because it is a linear search on an ArrayList using the Request object's equals method.
Instead, use the OkHttp tags feature for Calls to store the index as metadata that can be retrieved during response processing, so we can use that directly rather than doing a search.