-
Notifications
You must be signed in to change notification settings - Fork 14
tools: implement get taskrun logs #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
59a1868
to
1d342d3
Compare
83e9ed0
to
68e58f7
Compare
68e58f7
to
d2c5535
Compare
closes #25 |
@jbpratt needs a rebase 🙏🏼 |
d2c5535
to
7e1cc03
Compare
/hold going to refactor to test the mcp request/results like in #28 |
5bd34c3
to
c016c27
Compare
61c76cc
to
fab801d
Compare
/unhold |
fab801d
to
a62c972
Compare
/hold need to rewrite the tests similarly to the list tests |
1f1d09a
to
914a0ed
Compare
914a0ed
to
8062439
Compare
/unhold @vdemeester ready to go! PTAL when you've got a moment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to start sharing some code between cli, mcp, … for fetching the logs (and most likely have these common code in tektoncd/pipeline
).
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @waveywaves |
@jbpratt: GitHub didn't allow me to assign the following users: waveywaves. Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
with unit tests Signed-off-by: Brady Pratt <[email protected]>
and remove extra spaces at the end of the lines Signed-off-by: Brady Pratt <[email protected]>
8062439
to
d155838
Compare
Changes
compile the logs for each container in the taskrun's pod into a result
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Release Notes