Skip to content

tools: implement get taskrun logs #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jbpratt
Copy link
Contributor

@jbpratt jbpratt commented Apr 27, 2025

Changes

compile the logs for each container in the taskrun's pod into a result

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot requested a review from vdemeester April 27, 2025 23:00
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 27, 2025
@jbpratt jbpratt force-pushed the fetch-task-logs-tool branch from 59a1868 to 1d342d3 Compare April 28, 2025 08:41
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 28, 2025
@jbpratt jbpratt force-pushed the fetch-task-logs-tool branch 2 times, most recently from 83e9ed0 to 68e58f7 Compare April 28, 2025 12:45
@jbpratt jbpratt force-pushed the fetch-task-logs-tool branch from 68e58f7 to d2c5535 Compare April 28, 2025 15:24
@jbpratt
Copy link
Contributor Author

jbpratt commented Apr 28, 2025

closes #25

@jbpratt jbpratt mentioned this pull request Apr 30, 2025
6 tasks
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2025
@vdemeester
Copy link
Member

@jbpratt needs a rebase 🙏🏼

@jbpratt jbpratt force-pushed the fetch-task-logs-tool branch from d2c5535 to 7e1cc03 Compare April 30, 2025 17:13
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2025
@jbpratt
Copy link
Contributor Author

jbpratt commented Apr 30, 2025

/hold

going to refactor to test the mcp request/results like in #28

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2025
@jbpratt jbpratt force-pushed the fetch-task-logs-tool branch 2 times, most recently from 5bd34c3 to c016c27 Compare April 30, 2025 22:11
@jbpratt jbpratt changed the title tools: implement fetch taskrun logs tools: implement get taskrun logs Apr 30, 2025
@jbpratt jbpratt force-pushed the fetch-task-logs-tool branch 2 times, most recently from 61c76cc to fab801d Compare April 30, 2025 22:14
@jbpratt
Copy link
Contributor Author

jbpratt commented Apr 30, 2025

/unhold

@tekton-robot tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 30, 2025
@jbpratt jbpratt force-pushed the fetch-task-logs-tool branch from fab801d to a62c972 Compare May 6, 2025 21:53
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 6, 2025
@jbpratt
Copy link
Contributor Author

jbpratt commented May 6, 2025

/hold

need to rewrite the tests similarly to the list tests

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2025
@jbpratt jbpratt force-pushed the fetch-task-logs-tool branch from 1f1d09a to 914a0ed Compare May 7, 2025 21:51
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2025
@jbpratt jbpratt force-pushed the fetch-task-logs-tool branch from 914a0ed to 8062439 Compare May 7, 2025 21:52
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2025
@jbpratt
Copy link
Contributor Author

jbpratt commented May 7, 2025

/unhold

@vdemeester ready to go! PTAL when you've got a moment

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2025
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to start sharing some code between cli, mcp, … for fetching the logs (and most likely have these common code in tektoncd/pipeline).

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2025
@jbpratt
Copy link
Contributor Author

jbpratt commented May 16, 2025

/assign @waveywaves

@tekton-robot
Copy link

@jbpratt: GitHub didn't allow me to assign the following users: waveywaves.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @waveywaves

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jbpratt jbpratt requested a review from waveywaves May 16, 2025 08:59
jbpratt added 2 commits May 19, 2025 06:11
with unit tests

Signed-off-by: Brady Pratt <[email protected]>
and remove extra spaces at the end of the lines

Signed-off-by: Brady Pratt <[email protected]>
@jbpratt jbpratt force-pushed the fetch-task-logs-tool branch from 8062439 to d155838 Compare May 19, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants