You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 2, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @intellild ,
First of all, thank you for your efforts and please excuse us for the late reply.
You are correct that with Java 9, the version is printed on stdout. However, in JAVA 8, the javac -version is printed on the stderr. That's why the current code is reading the version from stderr.
Your fix will work for Java 9, but it will fail when Java 8 is used. That's why the unit tests are failing on this PR.
I've investigated the code and in fact we are not using the Java version detection - we care about Java Compiler version. So I've created a PR to remove the Java version detection and also fix the detection of Java Compiler version. You can take a look at the PR here.
So I'm closing this PR in favor of the other one.
Thanks again for your contribution - it allowed us to easily determine the issue with Java version detection and find the appropriate fix.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue:
NativeScript/nativescript-cli#3148