This repository was archived by the owner on Feb 2, 2021. It is now read-only.
fix(userSettings): Don't fail when user settings file is not a valid json #1059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
suggested changes
Mar 9, 2018
services/user-settings-service.ts
Outdated
| try { | ||
| this.userSettingsData = parseJson(data); | ||
| } catch (err) { | ||
| this.$logger.trace(`Error while trying to parseJson ${this.userSettingsFilePath} file.`); |
There was a problem hiding this comment.
can you add the error in the message and the data as well.
Fatme
force-pushed
the
fatme/user-settings-file
branch
from
4c074aa to
dd549da
Compare
rosen-vladimirov
approved these changes
Mar 9, 2018
…json
In case when user executes some command and by some reasons user settings file is not a valid json, {N} CLI throws "Unexpected token in JSON at position 0" error. After that user is not able to execute any cli command until the file exists.
Fatme
force-pushed
the
fatme/user-settings-file
branch
from
dd549da to
506ee87
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case when user executes some command and by some reasons user settings file is not a valid json, {N} CLI throws "Unexpected token in JSON at position 0" error. After that user is not able to execute any cli command until the file exists.
NativeScript/nativescript-cli#3151