This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Fix (publish): Remove binary-plist and use simple-plist instead #1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
Mar 26, 2018
plist-parser.ts
Outdated
| import * as simplePlist from "simple-plist"; | ||
|
|
||
| export class PlistParser implements IPlistParser { | ||
| public async parseFile(plistFilePath: string): Promise<any> { |
There was a problem hiding this comment.
there's no need to make this async
In case when produced Info.plist is not a binary file, `tns publish ios` command fails because `bplist-parser` is not able to parse non-binary plist files. This PR replaces `bplist-parser` module with `sample-plist` that is able to parse binary and non-binary files. Fixes NativeScript/nativescript-cli#3470
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case when produced Info.plist is not a binary file,
tns publish ioscommand fails becausebplist-parseris not able to parse non-binary plist files. This PR replacesbplist-parsermodule withsample-plistthat is able to parse binary and xml files.Fixes NativeScript/nativescript-cli#3470