This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Use TypeScript 2.0 #831
Merged
Use TypeScript 2.0 #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TsvetanMilanov
force-pushed
the
milanov/update-typescript-to-2.0
branch
from
c61e6d3 to
f0bfc4b
Compare
TsvetanMilanov
force-pushed
the
milanov/update-typescript-to-2.0
branch
from
f0bfc4b to
4fa565c
Compare
|
❤️ |
rosen-vladimirov
approved these changes
Nov 7, 2016
| @@ -10,6 +10,7 @@ $injector.require("errors", "./errors"); | |||
| $injector.requirePublic("fs", "./file-system"); | |||
| $injector.require("sysInfoBase", "./sys-info-base"); | |||
| $injector.require("hostInfo", "./host-info"); | |||
| $injector.require("osInfo", "./os-info"); | |||
There was a problem hiding this comment.
can we name this just "os", usually our naming convention is to use the same name used in Node.js
There was a problem hiding this comment.
Ok, the interface will be IoS, which is totally strange and will be confused with iOS, so osInfo is ok
| }); | ||
|
|
||
| after(() => { | ||
| os.type = osType; | ||
| os.release = osRelease; | ||
| osInfo.type = osType; |
There was a problem hiding this comment.
the after task should return everything in the correct way, so other tests will use the correct osInfo. In this case we set the type property of osInfo to something that is not the default value. Is this correct?
| @@ -1,5 +1,5 @@ | |||
| import Future = require("fibers/future"); | |||
| import * as prompt from "inquirer"; | |||
| import prompt = require("inquirer"); | |||
TsvetanMilanov
force-pushed
the
milanov/update-typescript-to-2.0
branch
from
4fa565c to
172f03a
Compare
|
❤️ |
Update the TS related dependencies to use TS 2.0 and fix the errors from the update
TsvetanMilanov
force-pushed
the
milanov/update-typescript-to-2.0
branch
from
172f03a to
16a4c64
Compare
|
❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the TS related dependencies to use TS 2.0 and fix the errors from
the update