This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Make devicesService.getDevice public #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`devicesService.getDevice` method returns device instance based on specified device identifier or number (from the list of devices). Make it public, so it can be used in `tns debug <platform>` command.
|
💔 |
nadyaA
approved these changes
Jul 10, 2017
| @@ -255,7 +255,7 @@ export class DevicesService extends EventEmitter implements Mobile.IDevicesServi | |||
| * Method expects running devices. | |||
| * @param identifier parameter passed by the user to --device flag | |||
| */ | |||
| private async getDevice(deviceOption: string): Promise<Mobile.IDevice> { | |||
| public async getDevice(deviceOption: string): Promise<Mobile.IDevice> { | |||
There was a problem hiding this comment.
Since the method becomes public, we may consider adding tests for it.
There was a problem hiding this comment.
I agree that the method needs separate tests, but currently it is already covered with tests, mainly here
TomaNikolov
approved these changes
Jul 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devicesService.getDevicemethod returns device instance based on specified device identifier or number (from the list of devices).Make it public, so it can be used in
tns debug <platform>command.