This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Print message when successfully setting the tns proxy configuration #991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 |
rosen-vladimirov
suggested changes
Jul 25, 2017
commands/proxy/proxy-set.ts
Outdated
| @@ -103,6 +103,8 @@ export class ProxySetCommand extends ProxyCommandBase { | |||
| this.$logger.warn(`Note that storing credentials is not supported on ${platform()} yet.`); | |||
| } | |||
|
|
|||
| this.$logger.warn("Note that 'npm' and 'Gradle' need to be configured separately to work with a proxy. Run 'tns proxy set --help' for more information."); | |||
There was a problem hiding this comment.
As this code is shared between AppBuilder and NativeScript CLI, you should use $staticConfig.CLIENT_NAME instead of tns in the message.
Also Gradle is not used in AppBuilder CLI.
Maybe we can place some if here to print the message only when we are in NativeScript CLI scenario.
There was a problem hiding this comment.
I did not consider that scenario, you are right!
petekanev
force-pushed
the
pete/proxy-set-info
branch
from
b81e8e5 to
b13d070
Compare
rosen-vladimirov
approved these changes
Aug 10, 2017
petekanev
force-pushed
the
pete/proxy-set-info
branch
from
b13d070 to
93a60e1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log a message instructing the user to run the
proxy sethelp command to find out how to setup thenpmandGradleproxy configurations.Implemented as suggested in NativeScript/nativescript-cli#2816
Related: NativeScript/nativescript-cli#3004