feat: enhance view component support #8

xHeaven · 2025-09-18T08:58:46Z

Improves the component view support within the IDE by:

Adding a "Go to Declaration" handler to navigate from a component tag to its corresponding template file.
Removing the tag name provider in favor of the new goto declaration handler.
Extending the descriptions and attributes in webTypes.json to provide more comprehensive documentation for components.
Using a transparent icon for XML tag autocompletion, improving visual clarity.

The previous implementation conflicts with webTypes.

Taken from the website.

xHeaven · 2025-09-18T09:00:58Z

Do we have any formatting requirement that should be enforced? Right now I just formatted the files with the defaults of IntelliJ IDEA.

github-actions · 2025-09-18T09:11:34Z

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

Register at Qodana Cloud and configure the action
Use GitHub Code Scanning with Qodana
Host Qodana report at GitHub Pages
Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

If the framework has `x-base` and the project also has `x-base`, the project-level `x-base` will override the framework-level one.

Can be invoked via `gradlew ktfmtCheck` and `gradlew ktfmtFormat`

xHeaven · 2025-09-18T17:10:50Z

@xepozz Could you take a look at this when you got time? What do you think? I'd merge it if it looks alright.

xepozz · 2025-09-21T09:40:36Z

Hey, @xHeaven !

Thanks for the PR

Adding a "Go to Declaration" handler to navigate from a component tag to its corresponding template file.

I think it's better to have reference-based platform instead of implementing direct reference calculation. References are more general. It's more convenient to create/pass/resolve a reference instead of creating another GoToDeclarationHandler.

Moreover, IDE does navigation by itself if any references under a mouse while clicking on it.

Removing the tag name provider in favor of the new goto declaration handler.

They does not equals by its own features, so there are 2 different mechanisms.

Extending the descriptions and attributes in webTypes.json to provide more comprehensive documentation for components.

Awesome

Using a transparent icon for XML tag autocompletion, improving visual clarity.

Awesome, should we do the same for the dark image?

xepozz · 2025-09-21T09:24:04Z

gradle.properties

 # Example: platformPlugins = com.jetbrains.php:203.4449.22, org.intellij.scala:2023.3.27@EAP
 #platformPlugins=com.jetbrains.php:243.25659.59,com.jetbrains.hackathon.indices.viewer:1.28
-platformPlugins=com.jetbrains.php:251.25410.129,com.jetbrains.hackathon.indices.viewer:1.28
+platformPlugins=com.jetbrains.php:253.17525.99,com.jetbrains.hackathon.indices.viewer:1.31


It would be better to support at least 4 previous major versions of the IDE.
2025.1 -> 2024.1, 2024.2, 2024.3, 2024.4
2025.2 -> 2024.2, 2024.3, 2024.4, 2025.1

Or as much as possible versions.

Could you please downgrade the plugin to the 242 and check if everything works great?

We can try, though there was a bit of a mess with the webTypes, because below 252.*.*, there are webSymbols.webTypes, above 252.*.* there are polySymbols.webTypes. I'll take a look. I don't like the way I did the webTypes at all, though, I think it should be entirely dynamic - or at least as much as possible. I just couldn't make it work. Could you maybe look into it? Then I'm fine with any version of the IDE.

Current web/poly types feature scope is to provide:

xml tag

xml attribute

description

That can be pretty done with custom references providers and description providers.

I have done a dynamic attributes provider. There should be another static provider for the default undeclared values. Like a map of tags and it's attributes.

Descriptions can be done with xml.attributeDescriptorsProvider and xml.elementDescriptorProvider extension points.
We can introduce another map, but I'd suggest to have one common map:

- tag: -- name -- description -- content type empty (`<tag />`) / required (`<tag >...</tag>`) / any -- attributes --- name --- description --- required/optional --- some helpful stuff -- some helpful stuff

and use it across the project via several helperes

xepozz · 2025-09-21T09:30:46Z

build.gradle.kts

    }
 }
+
+ktfmt { kotlinLangStyle() }


As for me it looks a bit ugly than it was

Also looks like there is a custom line length? Editor has a soft limit, but the formatter does not count it.

Is it possible to configure it? It'd fix all these issues before merge or in a separate PR

As far as I understood, kotlinfmt has very specific, non-configurable, opinionated setups. See: https://github.com/facebook/ktfmt#ktfmt-uses-a-2-space-indent-why-not-4-any-way-to-change-that

I went with the 4 space indent variant - that's what you see right now. The other is Google's opinionated version with 2 space indenting. Shall we try that?

I also don't necessarily want to opt-out of a specific formatter, since different IDEs and IDE setups will result in different formatting styles over the project, which can get nasty. We could say that we push a .idea-based formatting to the repo, but not every contributor will use JB IDEs so it won't enforce anything for them. I'm open to different formatting solutions as well, let me know what you think.

Let's leave code style "as is", there are more cons than pros using this formatter.
I usually use "optimize imports" option from the commit dialog in my IDEA.
To format a file a do cmd+option+l from time to time and that's totally fine for me.
To share a codestyle guides I usually use https://www.jetbrains.com/help/idea/editorconfig.html. VScode does support it as well.

but not every contributor will use JB IDEs

CI? :)

Anyway, I'd leave all as is. If you want to collapse/expand lines or anything else I don't mind.

xepozz · 2025-09-21T09:42:44Z