Expense example #201
Expense example #201
Conversation
| if not expense_id: | ||
| raise ValueError("expense id is empty") | ||
|
|
||
| async with httpx.AsyncClient() as client: |
There was a problem hiding this comment.
Consider making the activities as methods on a class that instantiates this in __init__ and reuses it. It is a bit better performance to reuse an HTTP client/connection and I think a better practice to demonstrate to users
| f"{EXPENSE_SERVER_HOST_PORT}/create", | ||
| params={"is_api_call": "true", "id": expense_id}, | ||
| ) | ||
| response.raise_for_status() |
There was a problem hiding this comment.
Technically 4xx is probably a ApplicationError with non_retryable=True, but that's a bit pedantic. But with this setup, an activity that, say, has invalid auth will retry forever
| # | ||
| # Activity completion is signaled in the `notify_expense_state_change` | ||
| # function in `ui.py`. | ||
| activity.raise_complete_async() |
There was a problem hiding this comment.
I see 8 years ago in the Go samples we used async activity completion. But another alternative that may be more popular these days is sending a signal on completion. See https://docs.temporal.io/activity-execution#when-to-use-async-completion. In this case, unless that external call is heartbeating and can react to cancellation, signal may be best. But not a big deal.
| start_to_close_timeout=timedelta(seconds=10), | ||
| ) | ||
| except Exception as err: | ||
| logger.error(f"Failed to create expense report: {err}") |
There was a problem hiding this comment.
Change to logger.exception if you want the exception info like message and stack trace automatically added
|
|
||
| [tool.uv] | ||
| default-groups = [ | ||
| "dev", | ||
| "bedrock", | ||
| "dsl", | ||
| "encryption", | ||
| "expense", |
There was a problem hiding this comment.
We accidentally added these default groups and we will remove them in #190
What was changed
Ported the expense example from Go to Python
Why?
Demonstrate human-in-the-loop processing and asynchronous activity completion
Checklist
Closes N/A
How was this tested:
Includes tests
Any docs updates needed?
README is updated