Skip to content

[Feature Request] Do not complete shutdown until all activities have returned and results pushed to server #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cretz opened this issue Aug 21, 2023 · 0 comments · Fixed by #681
Closed

[Feature Request] Do not complete shutdown until all activities have returned and results pushed to server #594

cretz opened this issue Aug 21, 2023 · 0 comments · Fixed by #681
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Aug 21, 2023 •
edited by sync-by-unito bot
Loading

Describe the solution you'd like

Today we are relying on lang (e.g. temporalio/sdk-python#370) to wait for all activities they start to finish completion so we can confirm the values are pushed to server. Ideally core should not complete shutdown with any outstanding activities or unpushed activity completions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wait for activity completes to reach server before shutdown Sushisource/sdk-core
1 participant
@cretz