Skip to content

Do not require heartbeating to be done in context #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

Do not require heartbeating to be done in context #504

merged 1 commit into from
Aug 11, 2025

Conversation

maciejdudko
Copy link
Contributor

What was changed

Fixed issue where we were accessing current context to get token for heartbeating.

Why?

Checklist

  1. Closes [Bug] Improperly accessing current activity context in outbound heartbeat #487

  2. How was this tested:
    Added test case ActivityWorkerTests.ExecuteActivityAsync_BackgroundThreadHeartbeat_Received

@maciejdudko maciejdudko requested a review from a team as a code owner August 7, 2025 19:43
cretz
cretz approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maciejdudko maciejdudko merged commit 6f27e45 into temporalio:main Aug 11, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Improperly accessing current activity context in outbound heartbeat
3 participants
@maciejdudko @cretz @Sushisource